116171 - "Binary File" links should try to send a nice content-type

Status: RESOLVED WONTFIX

(Webtools Graveyard :: MXR, defect)

Description

[Jeremy M. Dolan]

At the above URL, if you click "Binary File", LXR sends thumb-vrt-act.png as
text/plain, which is how Moz renders it. It's clearly a image/png by its
extention, LXR should check a mime.types file.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 151118 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 215047 has been marked as a duplicate of this bug. ***

Comment 3

[timeless]

*** Bug 230458 has been marked as a duplicate of this bug. ***

Comment 4

[Dave Miller [:justdave]]

reassigning endico's bugs to default owner

Comment 5

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 6

[J. Paul Reed [:preed]]

Reassigning all LXR bugs assigned to [e-mail] to the default LXR owner (sorry Bear!)

We aren't actively working on these (if that's wrong, please reassign to yourself/a real person). 

Comment 7

[timeless]

bad example. mxr-test already special cased images.

fixed on mxr-test see is_binary and get_mime_type in lib/LXR/Common.pm

Comment 8

[timeless]

So, for some cases mxr does the right thing...

svgz:
    http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hisc-action-bring_forward.svgz
    Binary File: http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hisc-action-bring_forward.svgz?raw=1&ctype=image/svg+xml

svg:
    http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hisc-action-artistictext-attach-path.svg
    Image:
http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hisc-action-artistictext-attach-path.svg?raw=1&ctype=image/svg+xml

This doesn't actually do the right thing:

png:
    http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hi48-app-key_bindings.png
    Image: http://mxr.meego.com/repo.meego.com/source/calligra/pics/hicolor/hi48-app-key_bindings.png?raw=1 <- actually, that's perhaps not ideal

http://mxr.meego.com/repo.meego.com/source/docbook-style-dsssl/images/

has a bunch of others which are probably not handled particularly well. Sadly I don't think eps or pdf are likely to change (they look like text!), but I should be able to fix the image cases.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

mxr is gone, mass closing.
https://searchfox.org/ is a much better alternative.