Closed
Bug 1161731
Opened 11 years ago
Closed 11 years ago
Various NS_WARNING statements in /gfx & /layout have unnecessary (and log-messying) "\n"
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file, 1 obsolete file)
|
8.55 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The vsync NS_WARNING statements added in bug 1102631 and bug 1128690 have terminal "\n" newlines, which makes for odd-looking logging like:
[Parent 20725] WARNING: Enabling vsync compositor
: file /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/gfx/layers/ipc/CompositorParent.cpp, line 669
Logging statements are supposed to be one-liners, but the newline puts the ":" at the start of the second line.
|
Assignee | |
Comment 1•11 years ago
|
||
Actually, there are a handful of these across /gfx; I'll just post a patch to fix all of 'em.
|
|
Assignee | |
Updated•11 years ago
|
Summary: vsync NS_WARNING statements have unnecessary (and log-messying) "\n" → Various NS_WARNING statements in /gfx have unnecessary (and log-messying) "\n"
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8601712 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Updating patch to fix one more instance, in layout/base/nsRefreshDriver.cpp. (the only instance of this in layout.)
Attachment #8601712 -
Attachment is obsolete: true
Attachment #8601717 -
Flags: review?(mstange)
|
|
||
Updated•11 years ago
|
Attachment #8601717 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Updated•11 years ago
|
Flags: in-testsuite-
Summary: Various NS_WARNING statements in /gfx have unnecessary (and log-messying) "\n" → Various NS_WARNING statements in /gfx & /layout have unnecessary (and log-messying) "\n"
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•