1161743 - Upgrade "WARNING: Not expiration-tracking an unlocked surface!" to an assertion

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Splitting this out of bug 1161722 in case it turns out that the assertion currently fires and this change gets backed out, but let's upgrade  "WARNING: Not expiration-tracking an unlocked surface!" in SurfaceCache.cpp to an NS_ASSERTION. It's a serious issue, as it implies corruption of internal data structures, and so we want to fail fast if any patch causes it to fire.

Comment 1

[Daniel Holbert [:dholbert]]

rs=me on s/NS_WARN_IF_FALSE/NS_ASSERTION/ for this warning.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: Upgrade 'WARNING: Not expiration-tracking an unlocked surface' to an assertion

Here's the patch.

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c7049e7e290

Comment 4

[Seth Fowler [:seth] [:s2h]]

Looks like the assertion didn't fire in that try job, so let's go ahead and land this.

Comment 5

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46dbbaed8618

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46dbbaed8618