Closed
Bug 1161743
Opened 9 years ago
Closed 9 years ago
Upgrade "WARNING: Not expiration-tracking an unlocked surface!" to an assertion
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
1.40 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Splitting this out of bug 1161722 in case it turns out that the assertion currently fires and this change gets backed out, but let's upgrade "WARNING: Not expiration-tracking an unlocked surface!" in SurfaceCache.cpp to an NS_ASSERTION. It's a serious issue, as it implies corruption of internal data structures, and so we want to fail fast if any patch causes it to fire.
Comment 1•9 years ago
|
||
rs=me on s/NS_WARN_IF_FALSE/NS_ASSERTION/ for this warning.
Updated•9 years ago
|
Attachment #8601724 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c7049e7e290
Assignee | ||
Comment 4•9 years ago
|
||
Looks like the assertion didn't fire in that try job, so let's go ahead and land this.
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46dbbaed8618
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46dbbaed8618
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•