1161771 - Don't treat flex items as having definite main sizes unless flex container has definite main size

Status: RESOLVED DUPLICATE of bug 1092007

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Spec change:
 https://hg.csswg.org/drafts/rev/8e208f535b2e

Updated spec text (with addition emphasized using "__"):
 # If a percentage is going to be resolved against a flex item’s main size,
 # and the flex item has a definite flex basis,
 # __and the flex container has a definite main size,__
 # the flex item’s main size must be treated as definite
 # for the purpose of resolving the percentage, and the
 # percentage must resolve against the flexed main size
 # of the flex item (that is, after the layout algorithm
 # below has been completed for the flex item’s flex
 # container, and the flex item has acquired its final size).

Testcase attached. It shows we match the spec text as it stood *before* this tweak. We need to change to match the updated spec-text.

Comment 1

[Daniel Holbert [:dholbert]]

Spec reference: http://dev.w3.org/csswg/css-flexbox-1/#definite-sizes

Comment 3

[Sam Sneddon [:gsnedders]]

With the spec having changed again, I think this is now a dupe of 1092007?

Comment 4

[Daniel Holbert [:dholbert]]

Yeah, basically.