Closed
Bug 1161796
Opened 9 years ago
Closed 9 years ago
Remove unused hardcoded english strings from Pocket
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
People
(Reporter: Dolske, Assigned: Dolske)
Details
Attachments
(1 file)
1.14 KB,
patch
|
jaws
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Bug 1155523 landed some strings that are no longer being used (due to using Pocket's own strings in dictionary.js). We should remove them.
Attachment #8601779 -
Flags: review?(jaws)
Updated•9 years ago
|
Attachment #8601779 -
Flags: review?(jaws) → review+
Updated•9 years ago
|
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Iteration: --- → 40.3 - 11 May
Points: --- → 1
Flags: in-testsuite-
Flags: firefox-backlog+
Updated•9 years ago
|
Flags: in-testsuite- → qe-verify-
Assignee | ||
Comment 2•9 years ago
|
||
(Also did a s/Send this page to Pocket/Save to Pocket/ for the toolbarbutton tooltip, per clarkbw's request)
https://hg.mozilla.org/mozilla-central/rev/1b8afe0fd9cd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8601779 [details] [diff] [review] Patch v.1 [Triage Comment] Required for 38.0.5 Pocket launch.
Attachment #8601779 -
Flags: approval-mozilla-release+
Attachment #8601779 -
Flags: approval-mozilla-aurora+
Comment 5•9 years ago
|
||
I'm not sure removing these strings is the best option from the l10n perspective. I also don't see why we'd need to clean this up on 38.0.5. Jeff - Will this cause any problems for l10n?
Flags: needinfo?(jbeatty)
Comment 6•9 years ago
|
||
This shouldn't have an impact on l10n. Do we have a bug on file to move these strings into l10n proper already? It'd be good to know that so that we know what we'll be doing at that point.
Flags: needinfo?(jbeatty)
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3a2712ad5ca4 https://hg.mozilla.org/releases/mozilla-release/rev/52bc3790d7b0
status-firefox38.0.5:
--- → fixed
status-firefox39:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•