Created attachment 8601779 [details] [diff] [review] Patch v.1 Bug 1155523 landed some strings that are no longer being used (due to using Pocket's own strings in dictionary.js). We should remove them.
Attachment #8601779 - Flags: review?(jaws)
Attachment #8601779 - Flags: review?(jaws) → review+
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Iteration: --- → 40.3 - 11 May
Points: --- → 1
(Also did a s/Send this page to Pocket/Save to Pocket/ for the toolbarbutton tooltip, per clarkbw's request)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8601779 [details] [diff] [review] Patch v.1 [Triage Comment] Required for 38.0.5 Pocket launch.
I'm not sure removing these strings is the best option from the l10n perspective. I also don't see why we'd need to clean this up on 38.0.5. Jeff - Will this cause any problems for l10n?
This shouldn't have an impact on l10n. Do we have a bug on file to move these strings into l10n proper already? It'd be good to know that so that we know what we'll be doing at that point.
status-firefox38.0.5: --- → fixed
status-firefox39: --- → fixed
You need to log in before you can comment on or make changes to this bug.