1161814 - [non-e10s] GMP crash reporting does not work on (at least) Windows

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) In a non-e10s tab, visit http://mozilla.github.io/webrtc-landing/pc_test.html on a device that has some kind of camera enabled
2) Make sure "Require H.264 video" is checked, and then click "Start"
3) You should see two feeds - the one on the right is live, the one on the left is being encoded via H.264.
4) Open about:config, and set (or add, if it's your first time) media.gmp.plugin.crash to true to crash the GMP process.

ER:

A notification bar should be displayed at the top of the http://mozilla.github.io/webrtc-landing/pc_test.html tab, telling you that the GMP crashed.

AR:

The left pane locks up, indicating that the GMP has stopped running, but there's no notification bar.

I've started bisecting. This hasn't worked on Windows since before April 5th, and stopped working sometime after March 5th.

I can't reproduce this on Dev Edition, and cpearce reports it working on Beta.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Last good nightly: 2015-04-02
First bad nightly: 2015-04-03

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2015-04-02&enddate=2015-04-03

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 1057908 is immediately suspect.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I've bisected this down to the patches from bug 1057908.

peterv - any idea what we need to do here?

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

peterv - Happy to take over if you don't have time for this. I've worked on the crash reporter before; But I'm still not 100% up to speed, so I'd probably be slower than you to resolve this issue!

Comment 5

[Peter Van der Beken [:peterv]]

I'll take a look tomorrow.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

jst said peterv was working on Important Things and that he didn't want peterv distracted, so we'll take gerald up on his offer to work on this.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

Uplift is happening soonish - we shouldn't lose track of this.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Looking into it. (Found 2 issues on the way that were blocking my debugging efforts: bug 1163456, bug 1163505)

After applying patches for the 2 bugs above, I cannot reproduce the issue (on win7-64, non-e10s) -- i.e., I do see the crash notification bar.
Tried with local debug&release builds, then also nightly 40.0a1 (2015-05-10).
I'll later try with older nightlies, see if I can reproduce it on 2015-04-03 as you had.

Can you still reproduce it with recent nightlies on your machine?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Huh. This appears to be working properly for me on Nightly, and on the tip of Aurora, so dropping tracking for 40.

I'll see if I can find the range where this got fixed.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

So I have confirmed that this is somehow working properly.

(Pro?)gression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2015-05-05&enddate=2015-05-06

Possibly bug 1146955 fixed this, but that'd be pretty surprising - I'm pretty sure I tested that case.