Use short nodes in "pull this review" message

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: gps, Unassigned)

Tracking

Details

(Reporter)

Description

4 years ago
Our message to pull commits:

   Pull down this commit:

   hg pull -r ea0113923c162d4b5ffb459a9f7d7559f8d8d3e2
   https://reviewboardhg.mozilla.org/version-control-tools/

is a bit excessive. We almost certainly don't need the full 40 characters of the SHA-1. The first 12 is fine and is consistent with the rest of Mercurial's UI.

Ideally, I think this message should be part of the MozReview web UI. If someone wants to morph this bug, go for it. Otherwise, I'm inclined to keep the scope tight and easy.
(Reporter)

Comment 1

4 years ago
Given http://www.jandemooij.nl/blog/2015/05/05/using-rust-to-generate-mercurial-short-hash-collisions/, how about WONTFIX. Let's fix this with UI changes instead. (Yes, I'm that paranoid about SHA-1.)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

3 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.