1161957 - Rename the openLines() function to make the intent clearer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

+++ This bug was initially created as a clone of Bug #1160337 +++

This is a quick follow up to bug 1160337 to address one of the review comments. The openLines()' function name implicitly suggests that it might return a boolean rather than a count. We should rename it numOpenLines().

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1161957-rename-open-lines > mozilla-b2g:master

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8602103 [details] [review]
[gaia] gabrielesvelto:bug-1161957-rename-open-lines > mozilla-b2g:master

Straightforward change, sorry for not having noticed your comment before landing in the parent bug.

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8602103 [details] [review]
[gaia] gabrielesvelto:bug-1161957-rename-open-lines > mozilla-b2g:master

Looks good, thanks. I left one comment on the PR just about our general approach to testing, but you can go ahead and land this as-is.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #3)
> Looks good, thanks. I left one comment on the PR just about our general
> approach to testing, but you can go ahead and land this as-is.

I agree that would be suitable for inclusion in unit-testing from a theoretical perspective but it's also so small and straightforward that I'm not sure if it's worth the extra run-time.

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29917

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ffb271da30565f8af80f1994a7f7c730e600ecc5