Closed
Bug 1161995
Opened 9 years ago
Closed 9 years ago
Places lock notification should use high-priority-global-notificationbox instead of the selected browser's notification box
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 41
People
(Reporter: dao, Assigned: abdelrahman, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
1.90 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The code is here: http://hg.mozilla.org/mozilla-central/annotate/60349cbc3d4e/browser/components/nsBrowserGlue.js#l1634 This should use win.document.getElementById("high-priority-global-notificationbox") rather than win.gBrowser.getNotificationBox(). Also, we can stop setting notification.persistence = -1;.
|
Assignee | |
Comment 1•9 years ago
|
||
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8606777 [details] [diff] [review] rev 1 - using high-priority-global-notificationbox Looks good, thanks!
Attachment #8606777 -
Flags: review?(dao) → review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ae5a3662ba4d https://hg.mozilla.org/mozilla-central/rev/4cedd3e2cc17
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•