1162000 - Bootstrap of fennec is failing

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: mach bootstrap log

Running this command:
./mach bootstrap
under Debian jessie does not provide a working environment to build fennec

It fails with:
 0:11.77 configure: error: not found. Please check your SDK for the subdirectory of build-tools. With the current configuration, it should be in /var/lib/jenkins/.mozbuild/android-sdk-linux/build_tools
 0:11.77 *** Fix above errors and then restart with\
 0:11.77                "/usr/bin/make -f client.mk build"
 0:11.77 /var/lib/jenkins/workspace/fennec-coverity/client.mk:363: recipe for target 'configure' failed

/var/lib/jenkins/.mozbuild/android-sdk-linux/build_tools does not exist.


=== mozconfig ===
ac_add_options --enable-debug --verbose
# Build Firefox for Android:
ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi

# With the following Android SDK and NDK:
ac_add_options --with-android-sdk="/var/lib/jenkins/.mozbuild/android-sdk-linux/platforms/android-21"
ac_add_options --with-android-ndk="/var/lib/jenkins/.mozbuild/android-ndk-r8e"

mk_add_options MOZ_MAKE_FLAGS="-j24"
=======

FYI:
~/.mozbuild$ find . -iname aapt|wc -l
0

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: ./mach build log

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: update-android-version.diff

The attached patch fixed the issue.

However, I think there is a bigger issue, we should fail the bootstrap when android build tools are not installed.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8602562 [details] [diff] [review]
update-android-version.diff

That doesn't seem right, but Nick will know better. I wonder if we actually need the first call to list_missing_android_packages to filter the presumed missing packages to install only them. If the android tool doesn't error out when provided packages that are already installed, we should maybe just pass the complete list.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: try.diff

I tried this one but it still doesn't install it.

Even if the log suggests it installed everything:
---
We are now installing the following Android packages:
tools, platform-tools, build-tools-21.1.2, android-21, extra-android-support, extra-google-google_play_services, extra-google-m2repository, extra-android-m2repository
---

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8602562 [details] [diff] [review]
update-android-version.diff

Review of attachment 8602562 [details] [diff] [review]:
-----------------------------------------------------------------

This should actually be 21.1.1, since that's what Gradle expects and automation uses:

checking for android build-tools directory... /builds/slave/fx-team-and-api-11-d-000000000/build/android-sdk-linux/build-tools/21.1.1

I meant to fix this myself and never got around to it.  sledru, can you see if 21.1.1 fixes your issue?  I'm surprised you see a problem with *any* version, tbh -- we definitely don't require 22+.

Comment 6

[Nick Alexander :nalexander [he/him]]

There's something weird happening here with build-tools vs. build_tools (hyphen vs. underscore).  sledru, what's you mozconfig like?  What's your on disk directory structure after |mach bootstrap|?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Sorry, i was too busy today with the 38 release (and it was an holidays for me)...
I will be in PTO next week. I will get back to you on this once I get back.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

> can you see if 21.1.1 fixes your issue?
Same issue.
Switching back to 22.0.1 makes it work.

> There's something weird happening here with build-tools vs. build_tools (hyphen vs. underscore).  
I am getting: /var/lib/jenkins/.mozbuild/android-sdk-linux/build-tools/

> what's you mozconfig like?
----
ac_add_options --enable-debug --verbose
# Build Firefox for Android:
ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi

# With the following Android SDK and NDK:
ac_add_options --with-android-sdk="/var/lib/jenkins/.mozbuild/android-sdk-linux/platforms/android-21"
ac_add_options --with-android-ndk="/var/lib/jenkins/.mozbuild/android-ndk-r8e"

mk_add_options MOZ_MAKE_FLAGS="-j24"
----

> What's your on disk directory structure after |mach bootstrap|?
/var/lib/jenkins/.mozbuild/android-ndk-r8e    
/var/lib/jenkins/.mozbuild/mozboot
/var/lib/jenkins/.mozbuild/android-sdk-linux
/var/lib/jenkins/.mozbuild/android-ndk-r8e/build
/var/lib/jenkins/.mozbuild/android-ndk-r8e/docs
/var/lib/jenkins/.mozbuild/android-ndk-r8e/documentation.html
/var/lib/jenkins/.mozbuild/android-ndk-r8e/GNUmakefile
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-build
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-build.cmd
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-gdb
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-gdb-py
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-gdb.py
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-gdb-py.cmd
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-stack
/var/lib/jenkins/.mozbuild/android-ndk-r8e/ndk-which
/var/lib/jenkins/.mozbuild/android-ndk-r8e/platforms
/var/lib/jenkins/.mozbuild/android-ndk-r8e/prebuilt
/var/lib/jenkins/.mozbuild/android-ndk-r8e/README.TXT
/var/lib/jenkins/.mozbuild/android-ndk-r8e/RELEASE.TXT
/var/lib/jenkins/.mozbuild/android-ndk-r8e/samples
/var/lib/jenkins/.mozbuild/android-ndk-r8e/sources
/var/lib/jenkins/.mozbuild/android-ndk-r8e/tests
/var/lib/jenkins/.mozbuild/android-ndk-r8e/toolchains
/var/lib/jenkins/.mozbuild/android-sdk-linux/add-ons
/var/lib/jenkins/.mozbuild/android-sdk-linux/build-tools
/var/lib/jenkins/.mozbuild/android-sdk-linux/extras
/var/lib/jenkins/.mozbuild/android-sdk-linux/platforms
/var/lib/jenkins/.mozbuild/android-sdk-linux/platform-tools
/var/lib/jenkins/.mozbuild/android-sdk-linux/SDK Readme.txt
/var/lib/jenkins/.mozbuild/android-sdk-linux/temp
/var/lib/jenkins/.mozbuild/android-sdk-linux/tools

Do you want to know more?

Comment 9

[Benjamin Smedberg]

Comment on attachment 8602562 [details] [diff] [review]
update-android-version.diff

This patch fixed a build error for me.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Fixed by bug 1165422, closing then.