Closed Bug 1162061 Opened 9 years ago Closed 8 years ago

Make offline_cache_whitelist and api_cdn_whitelist use route names instead of URLs

Categories

(Marketplace Graveyard :: Code Quality, enhancement, P3)

Avenir
enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mat, Unassigned)

References

Details

(Whiteboard: [ktlo][possible_future_need])

In our fireplace/our frontend projects we have 2 objects, offline_cache_whitelist and api_cdn_whitelist, that control whether API calls are cached offline or not and whether they use the CDN or not.

However, we have to specific the base URL to add entries in those objects. This sucks, because you can't add a URL that depend on a parameter, like the app API ('/api/v2/fireplace/app/{0}/') or the region API ('/api/v2/services/region/{0}/').

It should be possible, instead of URLs, to use route names, like 'app' or 'region'. (Query string should probably continue to be stripped from the URLs before making the comparisons, though)
Severity: normal → enhancement
Priority: -- → P3
If we do change this, could we also change the terminology away from whitelist please?
Whiteboard: [ktlo]
Hard to justify this enhancement at this time, but I agree that if it happens, "offline_cache_permitted_list" and "api_cdn_permitted_list" are worthy replacements.
Whiteboard: [ktlo] → [ktlo][possible_future_need]
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.