TestSafeBrowsingWarningPages.test_warning_pages doesn't test the expected support URL anymore

RESOLVED FIXED in Firefox 40

Status

Testing
Firefox UI Tests
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

({regression})

Version 3
mozilla40
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The work as done in bug 1157868 is not doing what it should do. Instead of comparing the loaded page with the target page, we now compare the target page with itself.

I will have a look at this.
(Assignee)

Comment 1

2 years ago
Talked with gcp on IRC and the underlying problem is in Firefox. So the landing of the change is even only a wallpaper which hides the real behavior of Firefox. The change in Firefox has been landed via bug 1147212.

It means we do not have to differentiate between phishing and malware anymore. We always redirect to SUMO now: https://hg.mozilla.org/mozilla-central/rev/8b191f5f9687#l4.65
(Assignee)

Updated

2 years ago
Keywords: regression
Summary: TestSafeBrowsingWarningPages.test_warning_pages doesn't test the expected url anymore → TestSafeBrowsingWarningPages.test_warning_pages doesn't test the expected support URL anymore
(Assignee)

Updated

2 years ago
Blocks: 1147212
(Assignee)

Comment 2

2 years ago
Created attachment 8602161 [details] [review]
github_pull_request.txt
Attachment #8602161 - Flags: review?(cmanchester)
Attachment #8602161 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla/firefox-ui-tests/commit/77d2a0ae6ad1f27f7458ac5279ee3d4b78e7115b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
(Assignee)

Comment 4

2 years ago
Somehow this change got reverted end of May so it was causing failures of the recent RC of Firefox 40.0 on the mozilla-release branch: https://treeherder.allizom.org/#/jobs?repo=mozilla-release&revision=a61c2305edd9

I re-landed it so tests should pass again:
https://github.com/mozilla/firefox-ui-tests/commit/3d760b3571d019f6d0cf39c19f2b9ecf96f9a113
status-firefox40: --- → fixed
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.