Arabic problems in convertUTF8toACE()

RESOLVED FIXED in Firefox 40

Status

()

Core
Internationalization
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gerv, Assigned: smontagu)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
I recently added the following entries to the Public Suffix List (over in bug 1161823):
 
// xn--mgbai9azgqp6j ("Pakistan", Urdu/Arabic) : PK
پاکستان

// xn--mgbai9a5eva00b ("Pakistan", Urdu/Arabic, variant) : PK
پاكستان

However, they caused netwerk/test/unit/test_bug414122.js to fail, as follows:

0:03.02 LOG: Thread-1 ERROR NS_ERROR_FAILURE: Component returned failure code: 
0x80004005 (NS_ERROR_FAILURE) [nsIIDNService.convertUTF8toACE]

Therefore, we had to back the changes out. Both of these entries seem to convert correctly in an online converter:
https://manage.centralnic.com/support/idn_converter

Is this a bug in our converter, or a problem with the entries?

Gerv
(Reporter)

Updated

3 years ago
Flags: needinfo?(smontagu)

Comment 1

3 years ago
Is is possible to comment the second, variant string, and re-test?
(Reporter)

Comment 2

3 years ago
Both strings cause a problem; removing only one didn't fix it. I have a reduced test case - I'll upload it.

Gerv
(Reporter)

Comment 3

3 years ago
Created attachment 8602283 [details]
effective_tld_names.dat

Make this your effective_tld_names.dat and then run the test.

Something odd is happening, though - when I copied and pasted back in from a patch, it worked. Is there some zero-width character in here or something which is causing an issue? More investigation tomorrow.

Gerv
(Assignee)

Comment 4

3 years ago
The entries contain a couple of Bidi control characters which fail the "prohibited character" test
(Assignee)

Comment 5

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09cd08e7bd1e
Flags: needinfo?(smontagu)
(Assignee)

Comment 6

3 years ago
Created attachment 8602291 [details] [diff] [review]
Add back the entries for Pakistan without the control characters
Assignee: nobody → smontagu
Attachment #8602291 - Flags: review?(gerv)
(Reporter)

Comment 7

3 years ago
Comment on attachment 8602291 [details] [diff] [review]
Add back the entries for Pakistan without the control characters

r=gerv.

Jothan: I don't know where you got these strings from, but you may want to let your source know about this potential problem. Their copies of the strings embed invisible characters which are not permitted.

Gerv
Attachment #8602291 - Flags: review?(gerv) → review+

Comment 8

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/45547d19c355
https://hg.mozilla.org/mozilla-central/rev/45547d19c355
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

Comment 10

3 years ago
Was cut-n-paste from the ICANN page - I wonder if the paste buffer into notepad++ did that?

Glad it is resolved
You need to log in before you can comment on or make changes to this bug.