Closed
Bug 1162211
Opened 9 years ago
Closed 9 years ago
Cache API should use sqlite private cache mode
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.09 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Cache uses OpenDatabaseWithFileURL() which gives us a shared sqlite cache by default. We don't need this feature and it adds some overhead. We should disable the shared cache by passing "cache=private" in the file URL.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8602274 -
Flags: review?(ehsan)
Updated•9 years ago
|
Attachment #8602274 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7257315c37a
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3347a2c69b7
Assignee | ||
Comment 4•9 years ago
|
||
Lots of orange on mulet in that last try. I think its due to the other patch in the try build. Here's a new try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f1d28de4413
Assignee | ||
Comment 5•9 years ago
|
||
Sigh. That didn't trigger a mulet test for some reason. Lets try this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa13c8256b6e
Assignee | ||
Comment 6•9 years ago
|
||
Last try demonstrates this patch did not cause the mulet M1 orange from previous try. I think its good to go once the tree opens.
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bec0992e81b5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•