Closed Bug 1162218 Opened 6 years ago Closed 6 years ago

Tighten up idle worker thread timeouts

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch, v1 (obsolete) — Splinter Review
The comment is correct and the test for the assertion is wrong.
Attachment #8602284 - Flags: review?(amarchesini)
Attachment #8602284 - Flags: review?(amarchesini) → review+
Actually there's more that can be done here. The timer code is a little loose at the moment.
Summary: Fix backwards assertion in RuntimeService → Tighten up idle worker thread timeouts
Attached patch Patch, v1Splinter Review
This is better. Now we don't keep the timer going longer than we should, and we don't assert because the timer may legitimately have nothing to do when it fires.
Attachment #8602284 - Attachment is obsolete: true
Attachment #8602430 - Flags: review?(amarchesini)
Comment on attachment 8602430 [details] [diff] [review]
Patch, v1

Review of attachment 8602430 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/RuntimeService.cpp
@@ +1812,5 @@
>      }
>    }
>  
> +  if (!nextExpiration.IsNull()) {
> +    TimeDuration delta = nextExpiration - TimeStamp::Now();

What about NowLoRes ?
Attachment #8602430 - Flags: review?(amarchesini) → review+
(In reply to Andrea Marchesini (:baku) from comment #3)
> What about NowLoRes ?

Yeah, that will be fine.
https://hg.mozilla.org/mozilla-central/rev/4dc03fc38885
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.