Closed
Bug 1162218
Opened 9 years ago
Closed 9 years ago
Tighten up idle worker thread timeouts
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(1 file, 1 obsolete file)
3.99 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
The comment is correct and the test for the assertion is wrong.
Attachment #8602284 -
Flags: review?(amarchesini)
Updated•9 years ago
|
Attachment #8602284 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 1•9 years ago
|
||
Actually there's more that can be done here. The timer code is a little loose at the moment.
Summary: Fix backwards assertion in RuntimeService → Tighten up idle worker thread timeouts
Assignee | ||
Comment 2•9 years ago
|
||
This is better. Now we don't keep the timer going longer than we should, and we don't assert because the timer may legitimately have nothing to do when it fires.
Attachment #8602284 -
Attachment is obsolete: true
Attachment #8602430 -
Flags: review?(amarchesini)
Comment 3•9 years ago
|
||
Comment on attachment 8602430 [details] [diff] [review] Patch, v1 Review of attachment 8602430 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/RuntimeService.cpp @@ +1812,5 @@ > } > } > > + if (!nextExpiration.IsNull()) { > + TimeDuration delta = nextExpiration - TimeStamp::Now(); What about NowLoRes ?
Attachment #8602430 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #3) > What about NowLoRes ? Yeah, that will be fine.
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc03fc38885
https://hg.mozilla.org/mozilla-central/rev/4dc03fc38885
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•