Closed Bug 1162224 Opened 5 years ago Closed 5 years ago
[STK] Browser Termination envelope not received
STR STR: - Run USAT GCF 22.214.171.124.1.1 - Card sends SET UP EVENT LIST: Browser Termination proactive command. - Start the browser app - Terminate the browser app by long pressing home button and closing the app Expected: STK download event when the browser is terminated Observed: No download event being sent
The issue seems to be that app.manifest.permissions.browser check at  is incorrect and therefore handleBrowserTerminationEvent function never gets called. Browser manifest url at  doesn't seem to have any entry for permissions.browser.  http://lxr.mozilla.org/gaia/source/apps/system/js/icc_events.js#262  http://lxr.mozilla.org/gaia/source/apps/search/manifest.webapp#30 Just as an experiment I changed the Gaia code to look at |app.manifest.name === 'Browser'| and then I received the envelope command as expected.
blocking-b2g: 2.2? → 2.2+
Comment on attachment 8602454 [details] [review] [gaia] weilonge:seanlee/STK/master/Bug1162224 > mozilla-b2g:master Hi Fernando, Could you help to review the patch? Thank you.
Attachment #8602454 - Flags: review?(frsela)
Hi! Sean, Since you are working on this case. Over to you. Thanks -- Keven
Assignee: nobody → selee
Comment on attachment 8602454 [details] [review] [gaia] weilonge:seanlee/STK/master/Bug1162224 > mozilla-b2g:master r+ to the patch. Thanks for fixing The browser app is changing since 2.0 (where permissions.browser exists ) and into the last releases it's merged inside system app . I'm worried that using the name for checking it, is a weak solution because it can be changed in the future, but not sure about a better solution now :(  https://github.com/mozilla-b2g/gaia/blob/v2.0m/apps/browser/manifest.webapp#L11  https://bugzilla.mozilla.org/show_bug.cgi?id=1043959
Attachment #8602454 - Flags: review?(frsela) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/d544c9b2a77a889d87566aff0ca957da5089a49e gaia-try: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=dbe4ba00e63dfd07d7e68e2ea309dc0662910388
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8602454 [details] [review] [gaia] weilonge:seanlee/STK/master/Bug1162224 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Browser Termination envelope is not received correctly. [Testing completed]: Write unit-test for this and it passes. [Risk to taking this patch] (and alternatives if risky): Only change how to check Browser app terminated. Very minor. [String changes made]: None.
Attachment #8602454 - Flags: approval-gaia-v2.2?
Attachment #8602454 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.