Closed Bug 1162242 Opened 9 years ago Closed 9 years ago

Remove usage of |#ifdef PR_LOGGING| from xpcom

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(3 files)

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Summary: Remove usage of |#idfef PR_LOGGING| from xpcom → Remove usage of |#ifdef PR_LOGGING| from xpcom
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8602317 - Flags: review?(nfroyd)
Now that PR_LOGGING is always defined DEBUG_TIMERS will always be set. It can
now be removed.
Attachment #8602318 - Flags: review?(nfroyd)
Removes redundant combinations of PR_LOG_TEST and PR_LOG.
Attachment #8602319 - Flags: review?(nfroyd)
Comment on attachment 8602319 [details] [diff] [review]
Part 3: Clean up usage of PR_LOG_TEST

Review of attachment 8602319 [details] [diff] [review]:
-----------------------------------------------------------------

Hah!
Attachment #8602319 - Flags: review?(nfroyd) → review+
Comment on attachment 8602317 [details] [diff] [review]
Part 1: Remove instances of #ifdef PR_LOGGING

Review of attachment 8602317 [details] [diff] [review]:
-----------------------------------------------------------------

It makes me a little nervous to remove all these checks, but I guess we've had these checks active for quite some time now...
Attachment #8602317 - Flags: review?(nfroyd) → review+
Attachment #8602318 - Flags: review?(nfroyd) → review+
You need to log in before you can comment on or make changes to this bug.