Closed
Bug 1162242
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from xpcom
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(3 files)
10.19 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
9.88 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
3.63 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Summary: Remove usage of |#idfef PR_LOGGING| from xpcom → Remove usage of |#ifdef PR_LOGGING| from xpcom
Assignee | ||
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8602317 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•9 years ago
|
||
Now that PR_LOGGING is always defined DEBUG_TIMERS will always be set. It can now be removed.
Attachment #8602318 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
Removes redundant combinations of PR_LOG_TEST and PR_LOG.
Attachment #8602319 -
Flags: review?(nfroyd)
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=139bf23d14af
Comment 5•9 years ago
|
||
Comment on attachment 8602319 [details] [diff] [review] Part 3: Clean up usage of PR_LOG_TEST Review of attachment 8602319 [details] [diff] [review]: ----------------------------------------------------------------- Hah!
Attachment #8602319 -
Flags: review?(nfroyd) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8602317 [details] [diff] [review] Part 1: Remove instances of #ifdef PR_LOGGING Review of attachment 8602317 [details] [diff] [review]: ----------------------------------------------------------------- It makes me a little nervous to remove all these checks, but I guess we've had these checks active for quite some time now...
Attachment #8602317 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8602318 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8a77e2a83f https://hg.mozilla.org/integration/mozilla-inbound/rev/917d62c82b1d https://hg.mozilla.org/integration/mozilla-inbound/rev/d7ae6f7c3e20
https://hg.mozilla.org/mozilla-central/rev/3c8a77e2a83f https://hg.mozilla.org/mozilla-central/rev/917d62c82b1d https://hg.mozilla.org/mozilla-central/rev/d7ae6f7c3e20
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•