1162244 - Adding L10n comment for Promo update (Each time)

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: General, defect, P5)

Description

[YF (Yang)]

File: https://github.com/mozilla/fireplace/blob/master/src/media/js/desktop_promo.js

The file should expose app_name of promo to translators. Adding the related bugzilla link (Each time) will better. Otherwise, the translation would be blind.


L10n comment maybe like the https://github.com/mozilla/fireplace/search?utf8=%E2%9C%93&q=+For+ages+{0}+and+higher.+%28de%29+%60ab+{0}+Jahren%60.

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/pull/1199

Not much we can do for the last extraction but I added the comments so that we know to add them next time.

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/c49fcd23f354206fbafaa3794af77bd9033e812a

Comment 3

[YF (Yang)]

Although I have seen it in the source code, but it seems that one will work only (and the incorrect) on localize.mozilla.org, and we need to find out why.


https://github.com/mozilla/fireplace/blob/26b9893b251740c836db69f9f35d03088a852e9d/src/media/js/desktop_promo.js#L15 have the "L10n: " field.
https://localize.mozilla.org/zh_CN/fireplace/translate.html#filter=incomplete&unit=3264674 "Comments" field take effect, but it not matching.
https://localize.mozilla.org/zh_CN/fireplace/translate.html#filter=incomplete&unit=3264681 "Comments" field not take effect.

Comment 4

[David Durst [:ddurst]]

desktop promos are going to be removed shortly.