1162254 - add default icon for entries in about:passwords list

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Allison Naaktgeboren :ally]

What icon might you like? :) The key?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks for filing this Ally. 

Since it's a "missing favicon" type fallback, I'm thinking not a 'key'. Something that we could reuse from elsewhere in our UI might be the "globe" or the "empty favicon" placeholder we use in Tablets.

Could you tell me what dimensions we need for this asset? I can give you one to stick in there :) 

Also, is about:passwords going to be web-based? I.e. do I need to prep this asset in MDPI -> XXHDPI?

Comment 3

[:Margaret Leibovic]

I thought Vivek already did this in bug 1103267.

Comment 4

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #3)
> I thought Vivek already did this in bug 1103267.

Oh maybe the problem here is bug 1140267.

Comment 5

[Vivek Balakrishnan[:vivek]]

Attachment: 1162254.patch

Favicon file name was changed as part of this change.
https://github.com/mozilla/gecko-dev/commit/6b971314933209a25cb1a43909e73d9bd3917af7#diff-fccef72d5fea102d28a00db112c8744c

Correct favicon file name updated in aboutPassword.css

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Ally, do we still need fallback favicons then?

Comment 7

[:Margaret Leibovic]

Comment on attachment 8603039 [details] [diff] [review]
1162254.patch

Review of attachment 8603039 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, oops, I didn't even realize that antlam wasn't part of bug 1103267. Assuming he's cool with using the default globe (I hope he is, no new assets ftw!), then this looks great. Good catch!

Comment 8

[Vivek Balakrishnan[:vivek]]

Attachment: favicon_password.png

Screenshot with favicon_globe (default favicon) shown due cache miss

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8603522 [details]
favicon_password.png

+ to get this moving for now, but the icon seems a bit large. 

Upon scrolling further, I noticed that (the few are coming in) some of the icons are getting stretched as well.

Ally, do you know what's going on here? or can you point me to the CSS and maybe I can give it a look over to see what specs we're using on these list items here?

Thanks Vivek!

Comment 10

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #9)

> Upon scrolling further, I noticed that (the few are coming in) some of the
> icons are getting stretched as well.
> 
> Ally, do you know what's going on here? or can you point me to the CSS and
> maybe I can give it a look over to see what specs we're using on these list
> items here?

Let's file a new bug for investigating the icon sizing problems.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/3437c01b624a

Comment 12

[Allison Naaktgeboren :ally]

I pulled & went to land this patch only to find that the changes have already in my latest copy of fxteam. ??

Comment 13

[Allison Naaktgeboren :ally]

oh. nm

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3437c01b624a

Comment 15

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Ally, is it me or has this replaced the globe icon in more places than just the about:passwords list? I'm looking at the "missing" favicon (globe) we use for display lists of links in all our panels UI, and the globe in the Top site tiles. There may be some I've missed.

Also, the globe in the tabs tray looks bigger now as well, or is it just me?

Comment 16

[Chenxia Liu [:liuche]]

Ok, so let me break this down into pieces:
1. Globe icon in home panels UI should be LIGHT not DARK
2. about:passwords icon should eventually be light

The tabs tray icon is the same size, but I noticed that compared to Beta, the icon is DARK not LIGHT

Let me hunt down the offending regressions...

Comment 17

[Allison Naaktgeboren :ally]

Chenxia's comments indicate its not just you.  Antlam, are there bugs on file for hte things that Chenxia discusses in comment 16?

Comment 18

[Chenxia Liu [:liuche]]

We decided this wasn't real.