Closed
Bug 1162309
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from docshell and uriloader
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files, 1 obsolete file)
24.34 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
9.42 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Assignee | ||
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8602399 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8602400 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d651ecfb9af1
Assignee | ||
Comment 4•9 years ago
|
||
Fix for non-debug builds.
Attachment #8602447 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Attachment #8602400 -
Attachment is obsolete: true
Attachment #8602400 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ade540a3da00
Updated•9 years ago
|
Attachment #8602399 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8602447 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cec43c89974 https://hg.mozilla.org/integration/mozilla-inbound/rev/b4ad8eababf5
https://hg.mozilla.org/mozilla-central/rev/6cec43c89974 https://hg.mozilla.org/mozilla-central/rev/b4ad8eababf5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•