Update the Pocket Toolbar @2x asset on OSX with the correct aspect ratios

VERIFIED FIXED in Firefox 38.0.5

Status

()

defect
P1
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mmaslaney, Assigned: jaws)

Tracking

38 Branch
Firefox 41
All
Other
Points:
1
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox38.0.5 verified, firefox39 verified, firefox40 verified, firefox41 verified)

Details

Attachments

(2 attachments)

Please update the attached @2x OSX toolbar asset.
Priority: -- → P5
Window Icons have the correct ratios.
Flags: needinfo?(mmaslaney)
Priority: P5 → P1
Posted patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8604676 - Flags: review?(dolske)
Iteration: --- → 41.1 - May 25
Flags: qe-verify?
Flags: firefox-backlog+
Points: --- → 1
Flags: qe-verify? → qe-verify+
Comment on attachment 8604676 [details] [diff] [review]
Patch

Review of attachment 8604676 [details] [diff] [review]:
-----------------------------------------------------------------

*stares at base64 encoding for a few minutes. LGTM!*
Attachment #8604676 - Flags: review?(dolske) → review+
Comment on attachment 8604676 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: the toolbar icon on osx hidpi is the wrong dimensions
[Describe test coverage new/current, TreeHerder]: none, just graphic swap
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8604676 - Flags: approval-mozilla-release?
Attachment #8604676 - Flags: approval-mozilla-beta?
Attachment #8604676 - Flags: approval-mozilla-aurora?
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/1bb87671b70a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8604676 [details] [diff] [review]
Patch

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604676 - Flags: approval-mozilla-release?
Attachment #8604676 - Flags: approval-mozilla-release+
Attachment #8604676 - Flags: approval-mozilla-beta?
Attachment #8604676 - Flags: approval-mozilla-beta+
Attachment #8604676 - Flags: approval-mozilla-aurora?
Attachment #8604676 - Flags: approval-mozilla-aurora+
Verified as fixed using a Retina MacBook with 10.9.5 on Firefox 38.0.5, Firefox 39 beta 1 #2, latest Aurora 40.0a2 and latest Nightly 41.0a1 2015-05-27.
You need to log in before you can comment on or make changes to this bug.