Closed
Bug 1162316
Opened 9 years ago
Closed 9 years ago
Update the Pocket Toolbar @2x asset on OSX with the correct aspect ratios
Categories
(Firefox :: General, defect, P1)
Tracking
()
People
(Reporter: mmaslaney, Assigned: jaws)
References
Details
Attachments
(2 files)
204.11 KB,
application/zip
|
Details | |
262.84 KB,
patch
|
Dolske
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-beta+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Please update the attached @2x OSX toolbar asset.
Updated•9 years ago
|
Priority: -- → P5
Comment 1•9 years ago
|
||
Do we need to update the Windows Toolbar icons too? http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/Toolbar@2x.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/Toolbar-aero@2x.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/Toolbar-inverted@2x.png
Flags: needinfo?(mmaslaney)
Updated•9 years ago
|
Priority: P5 → P1
Assignee | ||
Comment 3•9 years ago
|
||
Updated•9 years ago
|
Iteration: --- → 41.1 - May 25
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Updated•9 years ago
|
Points: --- → 1
Flags: qe-verify? → qe-verify+
Comment 4•9 years ago
|
||
Comment on attachment 8604676 [details] [diff] [review] Patch Review of attachment 8604676 [details] [diff] [review]: ----------------------------------------------------------------- *stares at base64 encoding for a few minutes. LGTM!*
Attachment #8604676 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8604676 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: pocket [User impact if declined]: the toolbar icon on osx hidpi is the wrong dimensions [Describe test coverage new/current, TreeHerder]: none, just graphic swap [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8604676 -
Flags: approval-mozilla-release?
Attachment #8604676 -
Flags: approval-mozilla-beta?
Attachment #8604676 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/1bb87671b70a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 8•9 years ago
|
||
Comment on attachment 8604676 [details] [diff] [review] Patch a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604676 -
Flags: approval-mozilla-release?
Attachment #8604676 -
Flags: approval-mozilla-release+
Attachment #8604676 -
Flags: approval-mozilla-beta?
Attachment #8604676 -
Flags: approval-mozilla-beta+
Attachment #8604676 -
Flags: approval-mozilla-aurora?
Attachment #8604676 -
Flags: approval-mozilla-aurora+
Comment 9•9 years ago
|
||
(aurora currently closed) https://hg.mozilla.org/releases/mozilla-beta/rev/b4689f3d86ac https://hg.mozilla.org/releases/mozilla-release/rev/21c86665a21d
Comment 11•9 years ago
|
||
Verified as fixed using a Retina MacBook with 10.9.5 on Firefox 38.0.5, Firefox 39 beta 1 #2, latest Aurora 40.0a2 and latest Nightly 41.0a1 2015-05-27.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•