1162321 - Show state of Bugzilla review flags in review dialog

Status: RESOLVED WONTFIX

(MozReview Graveyard :: General, defect, P3)

Description

[Gregory Szorc [:gps]]

When you click the "review" link you get a modal window with a "Ship It" checkbox and some textarea to enter comments.

I think we should add something in that window that shows the state of review flags in Bugzilla.

Some ideas:

1) Should the current list of flags and their state
2) Call attention to what will change if the form is submitted in its current state
3) Provide a checkbox to not cancel r? flag

#3 is kinda scope bloat. I think we should start with some visual reinforcement of what happens when you review something in MozReview so people aren't so confused about workflows.

Comment 1

[Mark Côté [:mcote]]

Note that we're moving from "ship it" to review flags in bug 1197879.

Comment 2

[Mark Côté [:mcote]]

We now support setting standard Bugzilla review flags in MozReview.  This should be the place where they're set; two-way mirroring is difficult and confusing.  WONTFIXing this.