Enable test_form_autocomplete_with_list.html for e10s

RESOLVED FIXED in Firefox 41

Status

()

Toolkit
Autocomplete
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

unspecified
mozilla41
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(e10sm7+, firefox41 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Over in bug 1024437, MattN noticed that the satchel tests are all disabled in e10s. We should get the re-enabled.

test_form_autocomplete.html has been disabled for a year and change and no longer passes (see bug 874429). Other than that test, the most useful one seems to be the _with_list.html variant. As I tried to enable it, though, I found several partially-implemented features in the e10s autocomplete code. I'll file bugs on what I found.
(Assignee)

Comment 1

3 years ago
Created attachment 8602455 [details] [diff] [review]
Fix the autocomplete popup opening with cached results

The e10s autocomplete popup doesn't pop back up if nsAutoCompleteController.cpp decides to reuse its cached autocomplete result. We need to detect when this happens and open the popup in the parent.
Attachment #8602455 - Flags: review?(felipc)
(Assignee)

Comment 2

3 years ago
Created attachment 8602456 [details] [diff] [review]
Fix display label vs. value

The current code only grabs the value, but datalist entries can have separate values (what's submitted/put in the input if selected) and labels (what's displayed in the autocomplete popup.
Attachment #8602456 - Flags: review?(felipc)
(Assignee)

Updated

3 years ago
Assignee: nobody → mrbkap
tracking-e10s: ? → m7+
Attachment #8602455 - Flags: review?(felipc) → review+
Attachment #8602456 - Flags: review?(felipc) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8607264 [details] [diff] [review]
Make dynamic changes to the datalist work

I was not able to make the test pass in its entirety. There are subtle timing problems that I wasn't able to make consistent across the e10s and non-e10s versions of the test. With the patches in this bug, then if I "nudge" the test by re-opening autocomplete menus when expected, the test passes. I'm going to leave the test in this state for the moment and file a followup bug to fix the timing problems.
Attachment #8607264 - Flags: review?(MattN+bmo)
(Assignee)

Updated

3 years ago
Attachment #8607264 - Attachment is obsolete: true
Attachment #8607264 - Flags: review?(MattN+bmo)
(Assignee)

Comment 5

3 years ago
Created attachment 8609043 [details] [diff] [review]
Implement autocompletion entry deletion for e10s.
Attachment #8609043 - Flags: review?(felipc)
Attachment #8609043 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/c4088483f340
https://hg.mozilla.org/mozilla-central/rev/c2550879e129
https://hg.mozilla.org/mozilla-central/rev/29ac9cb43e83
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

Updated

3 years ago
Depends on: 1230872
You need to log in before you can comment on or make changes to this bug.