Closed
Bug 1162331
Opened 9 years ago
Closed 9 years ago
refreshUpdateStatus incorrectly checks if the service should be used
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
3.37 KB,
patch
|
spohl
:
review+
|
Details | Diff | Splinter Review |
This is due to using shouldUseService which doesn't check if the maintenance service is installed.
Assignee | ||
Comment 1•9 years ago
|
||
This updates shouldUseService to also check if the service is installed and also updates the call sites that check both to only check shouldUseService.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8602435 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 2•9 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=204fba6e3139
Assignee | ||
Comment 3•9 years ago
|
||
Looks like the -tag argument didn't work with mochitest-chrome on try though it works locally
Assignee | ||
Comment 4•9 years ago
|
||
Filed bug 1162355 for comment #3
Assignee | ||
Comment 5•9 years ago
|
||
Pushed to try for the mochitest-o tests only https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c5756f05ac2
Comment 6•9 years ago
|
||
Comment on attachment 8602435 [details] [diff] [review] Patch rev1 Review of attachment 8602435 [details] [diff] [review]: ----------------------------------------------------------------- Great catch!
Attachment #8602435 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Updated•9 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/de4f4de880fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•