Closed Bug 1162331 Opened 4 years ago Closed 4 years ago

refreshUpdateStatus incorrectly checks if the service should be used

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

Details

Attachments

(1 file)

This is due to using shouldUseService which doesn't check if the maintenance service is installed.
Attached patch Patch rev1Splinter Review
This updates shouldUseService to also check if the service is installed and also updates the call sites that check both to only check shouldUseService.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8602435 - Flags: review?(spohl.mozilla.bugs)
Looks like the -tag argument didn't work with mochitest-chrome on try though it works locally
Comment on attachment 8602435 [details] [diff] [review]
Patch rev1

Review of attachment 8602435 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch!
Attachment #8602435 - Flags: review?(spohl.mozilla.bugs) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/de4f4de880fd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.