provisioner: Tag instances and spotRequests on a best-effort basis

RESOLVED FIXED

Status

Taskcluster
AWS-Provisioner
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jonasfj, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We should tag spot requests and EC2 instances on a best-effort basis.
Tagging helps tracking cost on the billing side.

I suggest the following tags:
Name:       <workerType>
Owner:      <provisionerId>
WorkerType: <provisionerId>/<workerType>
(note "Name" has special place in AWS console, I think "Owner" does too)

Remark, "Comment" is also a commonly used tag in AWS. If you can think of some
per request/instanceType information we would like to insert there as a string
we could do that.

But IMO, Name, Owner and WorkerType would go very far :)
Created attachment 8603327 [details]
commit

easy-peasy!
Attachment #8603327 - Flags: review?(jopsen)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8603327 [details]
commit

See comment for ES6/ES7 suggestions...

I don't like tags[][], or x(), but I see no better options.
---


Anyways, ship it... this will help cost a lot...
Attachment #8603327 - Flags: review?(jopsen) → review+
(Reporter)

Comment 3

3 years ago
Suggestion, I just realized that the tag "Application" is useful elsewhere.
How about we tag nodes with: {"Application": "taskcluster-worker"} ?

Should be trivial to add to the patch... Anyways, it's just a nit.
(Reporter)

Comment 4

3 years ago
I think you fixed this and rolled it out.. But figured I'd better ask.
Please confirm by resolving this as "Fixed", if it's fixed.
Flags: needinfo?(jhford)
Yep!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(jhford)
Resolution: --- → FIXED
Component: TaskCluster → AWS-Provisioner
Product: Testing → Taskcluster
You need to log in before you can comment on or make changes to this bug.