Closed Bug 1162341 Opened 5 years ago Closed 5 years ago

[P2P Sharing] Add-ons never appear in list

Categories

(Firefox OS Graveyard :: Gaia::P2P Sharing, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: drs)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

The following line is causing all add-ons to get filtered out and never show up in the listing:

https://github.com/fxos/sharing/blob/master/app/js/models/app.js#L45
Doug: Found this issue tonight.
Flags: needinfo?(drs)
Priority: -- → P1
Whiteboard: [spark]
This is better than what we had before, and fixes the issue described in the summary, but the app filter is still not great.

Any apps downloaded off of Marketplace, or side-loaded, or otherwise loaded by the user will be shareable. [1] But there's still a question about what apps should be initially shareable out of the box.

With this patch, the following apps are shareable initially:

* BuddyUp
* Webmaker
* Firefox Hello
* Calculator
* Foxfooding
* Notes
* Yammer
* Facebook
* Twitter
* Bugzilla Lite
* Sechelt
* HexGL

My thoughts on keeping these shareable is because they're all removable, and they are apps that don't already come preloaded on other FxOS devices. Thus, a Spark user may want to share them with a non-Spark user. I think that this reasoning weak, but I also think that it's bad to not have any apps shareable out of the box.

Jacqueline, Patryk, any thoughts on this?

[1] "Shareable" means that you can toggle sharing of it on/off within the settings menu in the Sharing app. When sharing of an app is enabled, others can download it. If an app isn't shareable, it doesn't appear in the list, and can't be shared.
Assignee: nobody → drs
Status: NEW → ASSIGNED
Flags: needinfo?(drs)
Attachment #8604475 - Flags: ui-review?(padamczyk)
Attachment #8604475 - Flags: ui-review?(jsavory)
Attachment #8604475 - Flags: review?(jdarcangelo)
Comment on attachment 8604475 [details] [review]
Improve criteria for listing apps as shareable.

LGTM, thanks!
Attachment #8604475 - Flags: review?(jdarcangelo) → review+
Yes that makes sense to me, all the apps that you get from the marketplaces which we preloaded should be shareable. Most of the spark users will likely be around other spark users so it might be weird having all these apps "ON" for shareablility by default, perhaps we would list with the toggle set to "OFF" right off the bat, and all new downloaded apps after that would have shareable toggle set to as "ON" by default.
Blocks: 1164172
Comment on attachment 8604475 [details] [review]
Improve criteria for listing apps as shareable.

(In reply to Patryk Adamczyk [:patryk] UX from comment #4)
> Yes that makes sense to me, all the apps that you get from the marketplaces
> which we preloaded should be shareable. Most of the spark users will likely
> be around other spark users so it might be weird having all these apps "ON"
> for shareablility by default, perhaps we would list with the toggle set to
> "OFF" right off the bat, and all new downloaded apps after that would have
> shareable toggle set to as "ON" by default.

Good idea, thanks for your input. I've filed bug 1164172 where I'll make these changes. I'm going to land this as-is for now.
Attachment #8604475 - Flags: ui-review?(padamczyk)
Attachment #8604475 - Flags: ui-review?(jsavory)
https://github.com/fxos/sharing/commit/ad967bd816741bf18d26563de50e48fa415f48d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.