Closed
Bug 1162349
Opened 9 years ago
Closed 9 years ago
integration tests for context menu
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
Since the context menu is operated by keyboard, we should create a integration tests to operate it with keyboard and check if the focus and style is updated.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8602581 [details] [review] [gaia] huchengtw-moz:bug-1162349-integration-tests-context-menu > mozilla-b2g:master Hi, Since this is the first integration test, it would be nice to be reviewed by two people. Please review it. Thanks.
Attachment #8602581 -
Flags: review?(rexboy)
Attachment #8602581 -
Flags: review?(chens)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8602581 [details] [review] [gaia] huchengtw-moz:bug-1162349-integration-tests-context-menu > mozilla-b2g:master Looks good to me, left some comments on github.
Attachment #8602581 -
Flags: review?(chens) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8602581 [details] [review] [gaia] huchengtw-moz:bug-1162349-integration-tests-context-menu > mozilla-b2g:master Smart-system part looks good to me. I'm not familiar with marionette test so I just read the test once and they seems ok to me. Thanks a lot!
Attachment #8602581 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → im
|
|
Assignee | |
Comment 5•9 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/f4f129fc8cf2fe450b8abdc52e7e72863d8c08ac tree herder is all green: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=90beb7412fb8833fb318bc8cc5e21e8d5d8323cb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•