1162384 - [NFC] Cannot share image which is opened from notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Build ID               20150506160205
Gaia Revision          426fe6450ab8da92bb473fef12ccb39c6c920dd0
Gaia Date              2015-05-06 08:40:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5593ac626826
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150506.193508
Firmware Date          Wed May  6 19:35:21 EDT 2015
Bootloader             L1TC100118D0

STR:
1. Receive a image from other device
2. Open the image from notification
3. While viewing image from notification, set back to other device to initiate an NFC transfer
4. Try to swipe shrinking UI to share file

Expected result:
Can swipe shrinking UI to share file

Actual result:
Cannot swipe shrinking UI  (http://youtu.be/HxqKOxSQZp8)

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Regression issue

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: regression, function broken

Comment 3

[David Flanagan [:djf]]

Weird. There have been very few gaia changes here between 2.2 and 3.0. Unless the jshint compliance patch messed something up, I suspect this is a gecko issue.

Punam: I'm tied up with other gallery image memory bugs. You know the NFC code and spark. Could you help investigate this and determine whether it is something broken in Gallery?

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Ni gecko developer and see their opinions on comment 3.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

notification should be related to system app changes, 
and we didn't do any major change after v2.2

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni Alive to comment from system app.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Delivering NI to George, please help to check what's happening here, thanks.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

b2g inbound regression window:

Last Working
Device: Flame
BuildID: 20150504041100
Gaia: 1336ecf1b157824c61c93b81b1759399a80fae2b
Gecko: ea65aaa6b1ae
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken
Device: Flame
BuildID: 20150504044407
Gaia: c48bc387de07f9eb005fa37a4c315e39bab9b6c6
Gecko: c8f17c8ae839
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: 1336ecf1b157824c61c93b81b1759399a80fae2b
Gecko: c8f17c8ae839

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: c48bc387de07f9eb005fa37a4c315e39bab9b6c6
Gecko: ea65aaa6b1ae

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/1336ecf1b157824c61c93b81b1759399a80fae2b...c48bc387de07f9eb005fa37a4c315e39bab9b6c6

Caused by bug 1158379.

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

George, can you take a look at this please? This might have been caused by the landing for bug 1158379.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:1162384 > mozilla-b2g:master

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8605004 [details] [review]
[gaia] cctuan:1162384 > mozilla-b2g:master

Hi Alive, 
Could you help me to review this patch?
I found that I should return frontWindow's _showScreenshotOverlay if app has frontWindow, otherwise, the callback will never be triggered.

Thanks.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8605004 [details] [review]
[gaia] cctuan:1162384 > mozilla-b2g:master

r+ with nit

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

merge to master: https://github.com/mozilla-b2g/gaia/commit/3fc22ca62b56276f264cc0e7c1276bd5e877e2be

Comment 14

[Alison Shiue]

Verified on

Build ID               20150518160201
Gaia Revision          762cbd16712484f93f485e89f5363686540a3db7
Gaia Date              2015-05-18 18:07:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e94dc650c901
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150518.194829
Firmware Date          Mon May 18 19:48:46 EDT 2015
Bootloader             HHZ12f

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Since we are about to land bug 1158379 to 2.2, this one will be 2.2:affected so we'll need to uplift it as well.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8605004 [details] [review]
[gaia] cctuan:1162384 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This commit is to fix regression of bug 1158379.
[User impact] if declined: User might see pb as comment 0.
[Testing completed]: Yes, cover manual and unit test.
[Risk to taking this patch] (and alternatives if risky): This bug should be merged to 2.2 later than bug 1158379.
[String changes made]:

Comment 17

[Josh Cheng [:josh]]

Comment on attachment 8605004 [details] [review]
[gaia] cctuan:1162384 > mozilla-b2g:master

Approving and requesting QA verifyme after patch land on 2.2

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e6107c745068cf6fbf23494f9d17c1a1fa335865

Comment 19

[Alison Shiue]

Verified on v2.2:
Build ID               20150526162504
Gaia Revision          15fa6e486b5c82956a8e8f8a99c39d297e8f0523
Gaia Date              2015-05-26 20:07:31
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/663bf4703588
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150526.201446
Firmware Date          Tue May 26 20:14:55 EDT 2015
Bootloader             L1TC100118D0