Implement Browser.EXTRA_CREATE_NEW_TAB

VERIFIED FIXED in Firefox 40

Status

()

Firefox for Android
General
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: TeoVermesan, Assigned: mcomella)

Tracking

40 Branch
Firefox 41
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox40 verified, firefox41 verified, fennec40+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Steps to reproduce:
1. Go to gmail app inbox and tap on a link and open it with Nightly
2. Tap on another link to open it with Nightly

Expected results:
- After step 2, there should be two new tabs with the two links

Actual results:
- When trying to open the second link, it loads in the same tab as the first

Note:
- this is reproducible with "Open multiple links" disabled
- if "Open multiple links" is enabled, the issue is reproducible when tapping the "Open now" button from the toast notification after tapping a link
- the issue is not reproducible when tapping the "Nightly - 1 tab waiting" notification from the android notification bar
- this is a regression:
05-05 build: not affected:
06-05 build: afected
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c93d46ab92f&tochange=60349cbc3d4e

Bug 1159718 - Remove notification when 'quick open' is activated in Tab Queue ?
I can't replicate with current nightly (05-07) on 5.1 with my N6 but I can reproduce on my N7 running 4.3
I would point some blame at bug 840574, which is all about opening external URLs into the same tab.
Flags: needinfo?(michael.l.comella)
(In reply to Mark Finkle (:mfinkle) from comment #2)
> I would point some blame at bug 840574, which is all about opening external
> URLs into the same tab.

Sounds reasonable.
Assignee: nobody → michael.l.comella

Updated

3 years ago
tracking-fennec: --- → ?
Teodora, are there other apps that are acting unexpectedly?

It seems gmail acutally gives us an explicit appId ("com.google.android.gm") and things are working as I would expect them to even though Chrome and the stock browser handles this differently.

There can't be an extra flag we need to set for EXTRA_APPLICATION_ID to take hold because Chrome and the stock browser correctly handle my test app, which has no such flags. Either there is a "don't use the application ID"-flag (or similar) or the other browsers are special-casing Gmail.
Flags: needinfo?(michael.l.comella) → needinfo?(teodora.vermesan)
Summary: External links are loaded in the same tab in Nightly → Gmail links are loaded in the same tab in Nightly
(In reply to Michael Comella (:mcomella) from comment #4)
> Either there is a "don't use the application
> ID"-flag (or similar)

Well, that was easy: https://developer.android.com/reference/android/provider/Browser.html#EXTRA_CREATE_NEW_TAB
Flags: needinfo?(teodora.vermesan)
Summary: Gmail links are loaded in the same tab in Nightly → Implement Browser.EXTRA_CREATE_NEW_TAB
Created attachment 8604237 [details]
MozReview Request: bz://1162423/mcomella

/r/8575 - Bug 1162423 - Handle Browser.EXTRA_CREATE_NEW_TAB. r=margaret
/r/8577 - Bug 1162423 - Dummy commit to be removed so I can push these a single commit to reviewboard. r=me

Pull down these commits:

hg pull -r 40df90997302d59e1418433525bf0048526231a8 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8604237 - Flags: review?(margaret.leibovic)

Updated

3 years ago
Attachment #8604237 - Flags: review?(margaret.leibovic) → review+

Comment 7

3 years ago
Comment on attachment 8604237 [details]
MozReview Request: bz://1162423/mcomella

https://reviewboard.mozilla.org/r/8507/#review7205

Ship It!
https://hg.mozilla.org/mozilla-central/rev/53b1c6496172
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
tracking-fennec: ? → 40+
(Reporter)

Comment 10

3 years ago
Gmail links are loaded in separate tabs in nightly, so:
Verified fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 41.0a1 (2015-05-17)
status-firefox41: fixed → verified
Comment on attachment 8604237 [details]
MozReview Request: bz://1162423/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 840574
[User impact if declined]:
  Users using non-Fennec apps that use the EXTRA_BROWSER_ID when opening Fennec may open all pages in the same tab (because the EXTRA_CREATE_NEW_TAB flag that is associated with EXTRA_BROWSER_ID is not interpretted).

[Describe test coverage new/current, TreeHerder]:
  Tested locally, on Nightly, verified by QA

[Risks and why]:
  This change really only touches the application ID code so in the worst case, we break that. I'd say this is low risk because the change only moves around some already working arguments and then adds the additional EXTRA_CREATE_NEW_TAB flag.
  
[String/UUID change made/needed]: None
Attachment #8604237 - Flags: approval-mozilla-aurora?
Attachment #8604237 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Comment 13

3 years ago
Gmail links are loaded in separate tabs, so:
Verified fixed using:
Device: Samsung S5 (Android 4.4.4)
Build: Firefox for Android 40.0a2 (2015-05-27)
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Comment on attachment 8604237 [details]
MozReview Request: bz://1162423/mcomella
Attachment #8604237 - Attachment is obsolete: true
Attachment #8620249 - Flags: review+
Attachment #8620250 - Flags: review+
Created attachment 8620249 [details]
MozReview Request: Bug 1162423 - Dummy commit to be removed so I can push these a single commit to reviewboard. r=me
Created attachment 8620250 [details]
MozReview Request: Bug 1162423 - Handle Browser.EXTRA_CREATE_NEW_TAB. r=margaret
You need to log in before you can comment on or make changes to this bug.