Closed Bug 1162456 Opened 5 years ago Closed 5 years ago

Rename --tinderbox option to --format=automation in jstests and jit-test.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox-esr38 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(2 files)

Separated from bug 1161410 and bug 1156045.

bug 1161410 renames --tbpl to --jitflags. --tinderbox should also be renamed to self-descriptive one, keeping --tinderbox as an alias for it.
Prepared 2 patches, just same as previous one.
--format can be 'automation' or 'none' (not sure 'none' is appropriate here though)

Almost green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d39634ce4c28
Assignee: nobody → arai.unmht
Attachment #8602900 - Flags: review?(sphink)
And changes for scripts which pass it.
Attachment #8602902 - Flags: review?(sphink)
Comment on attachment 8602900 [details] [diff] [review]
Part 1: Add --format option in jstests.py and jit_test.py as a replacement for --tinderbox.

Review of attachment 8602900 [details] [diff] [review]:
-----------------------------------------------------------------

It's a little weird, since the flag seems to really be about additionally emitting automation-parsable information, but it's good enough and way better than --tinderbox. Thanks!

::: js/src/tests/lib/jittests.py
@@ +472,5 @@
>  
>      return True
>  
> +def print_automation_format(ok, res):
> +    # Output test failures in a automation parsable format, eg:

# Output test failures in a parsable format suitable for automation, eg:
Attachment #8602900 - Flags: review?(sphink) → review+
Attachment #8602902 - Flags: review?(sphink) → review+
You need to log in before you can comment on or make changes to this bug.