Closed
Bug 1162456
Opened 9 years ago
Closed 9 years ago
Rename --tinderbox option to --format=automation in jstests and jit-test.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(2 files)
11.04 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
5.29 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Separated from bug 1161410 and bug 1156045. bug 1161410 renames --tbpl to --jitflags. --tinderbox should also be renamed to self-descriptive one, keeping --tinderbox as an alias for it.
Assignee | ||
Comment 1•9 years ago
|
||
Prepared 2 patches, just same as previous one. --format can be 'automation' or 'none' (not sure 'none' is appropriate here though) Almost green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d39634ce4c28
Assignee: nobody → arai.unmht
Attachment #8602900 -
Flags: review?(sphink)
Assignee | ||
Comment 2•9 years ago
|
||
And changes for scripts which pass it.
Attachment #8602902 -
Flags: review?(sphink)
Comment 3•9 years ago
|
||
Comment on attachment 8602900 [details] [diff] [review] Part 1: Add --format option in jstests.py and jit_test.py as a replacement for --tinderbox. Review of attachment 8602900 [details] [diff] [review]: ----------------------------------------------------------------- It's a little weird, since the flag seems to really be about additionally emitting automation-parsable information, but it's good enough and way better than --tinderbox. Thanks! ::: js/src/tests/lib/jittests.py @@ +472,5 @@ > > return True > > +def print_automation_format(ok, res): > + # Output test failures in a automation parsable format, eg: # Output test failures in a parsable format suitable for automation, eg:
Attachment #8602900 -
Flags: review?(sphink) → review+
Updated•9 years ago
|
Attachment #8602902 -
Flags: review?(sphink) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f009f29b2311 https://hg.mozilla.org/integration/mozilla-inbound/rev/50b14adaa353
https://hg.mozilla.org/mozilla-central/rev/f009f29b2311 https://hg.mozilla.org/mozilla-central/rev/50b14adaa353
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/9d6eae8f4c6e https://hg.mozilla.org/releases/mozilla-beta/rev/ec01909d713e
status-firefox39:
--- → fixed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/b79d0932694d https://hg.mozilla.org/releases/mozilla-esr38/rev/8f3b8530327c
status-firefox-esr38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•