Closed Bug 1162460 Opened 9 years ago Closed 9 years ago

[Cleanup] Remove trailing space in Gaia bluetooth code

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ben.tian, Assigned: ben.tian)

Details

Attachments

(1 file, 2 obsolete files)

[gaia] bentian:bug-1162420 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
iliu
: review+
Details | Review 
      No description provided.
Assignee: nobody → btian

        Attachment #8602663 -
        Flags: review?(iliu)

    
  

        Attachment #8602660 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8602663 [details] [review]
[gaia] bentian:bug-1162460 > mozilla-b2g:master

Ben, Thanks for your follow up. If you want to cleanup all trailing space of Gaia Bluetooth code base, you have to do the same thing for the other modules in Settings app. Basically, they are almost duplication.

apps/settings/js/modules/bluetooth/bluetooth_context.js
apps/settings/test/unit/modules/bluetooth/bluetooth_connection_manager_test.js
apps/settings/test/unit/modules/bluetooth/bluetooth_context_test.js

        Attachment #8602663 -
        Flags: review?(iliu)

    
    

    
  
Comment on attachment 8603125 [details] [review]
[gaia] bentian:bug-1162420 > mozilla-b2g:master

Revise per Ian's suggestion.

        Attachment #8603125 -
        Flags: review?(iliu)

    
  

        Attachment #8602663 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8603125 [details] [review]
[gaia] bentian:bug-1162420 > mozilla-b2g:master

Thanks for Ben's help with patience. r+ with me.

        Attachment #8603125 -
        Flags: review?(iliu) → review+

    
    

    
  
Since the patch is landed, we can close the issue now.

Gaia/master: https://github.com/mozilla-b2g/gaia/commit/e435a56f4a191b19311a582765b511b32cf88087
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: