Closed Bug 1162483 Opened 11 years ago Closed 10 years ago

web-animations/animation-timeline/document-timeline.html is going to permafail when Gecko 40 merges to Beta

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: RyanVM, Assigned: jgraham)

References

Details

Attachments

(1 file, 1 obsolete file)

animations-pref.diff
535 bytes, patch
Ms2ger
: review+
Details | Diff | Splinter Review
https://treeherder.mozilla.org/logviewer.html#?job_id=7276887&repo=try 11:52:35 INFO - TEST-START | /web-animations/animation-timeline/document-timeline.html 11:52:35 INFO - PROCESS | 1856 | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts). 11:52:35 INFO - PROCESS | 1856 | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14 11:52:35 INFO - PROCESS | 1856 | nsBrowserAccess.prototype.openURI@chrome://browser/content/browser.js:15578:21 11:52:35 INFO - PROCESS | 1856 | __marionetteFunc@dummy file:19:30 11:52:35 INFO - PROCESS | 1856 | @dummy file:28:3 11:52:35 INFO - PROCESS | 1856 | executeWithCallback@chrome://marionette/content/listener.js:754:5 11:52:35 INFO - PROCESS | 1856 | executeAsyncScript@chrome://marionette/content/listener.js:650:3 11:52:35 INFO - TEST-UNEXPECTED-FAIL | /web-animations/animation-timeline/document-timeline.html | document.timeline identity tests - assert_not_equals: document.timeline returns a different object for each document got disallowed value undefined 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:15:1 11:52:35 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1316:20 11:52:35 INFO - test@http://web-platform.test:8000/resources/testharness.js:449:9 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:11:1 11:52:35 INFO - TEST-UNEXPECTED-FAIL | /web-animations/animation-timeline/document-timeline.html | document.timeline.currentTime value tests - document.timeline is undefined 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:28:3 11:52:35 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1316:20 11:52:35 INFO - async_test@http://web-platform.test:8000/resources/testharness.js:466:13 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:27:1 11:52:35 INFO - TEST-UNEXPECTED-FAIL | /web-animations/animation-timeline/document-timeline.html | document.timeline.currentTime liveness tests - document.timeline is undefined 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:68:7 11:52:35 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1316:20 11:52:35 INFO - async_test@http://web-platform.test:8000/resources/testharness.js:466:13 11:52:35 INFO - @http://web-platform.test:8000/web-animations/animation-timeline/document-timeline.html:67:1 11:52:35 INFO - TEST-OK | /web-animations/animation-timeline/document-timeline.html | took 219ms
Flags: needinfo?(james)
Attached patch inputmode-pref.diff (obsolete) — — Splinter Review
Flags: needinfo?(james)
Attachment #8617833 - Flags: review?(Ms2ger)
Attachment #8617833 - Attachment is obsolete: true
Attachment #8617833 - Flags: review?(Ms2ger)
Attachment #8617835 - Flags: review?(Ms2ger)
Attachment #8617835 - Flags: review?(Ms2ger) → review+
Assignee: nobody → james
https://hg.mozilla.org/mozilla-central/rev/5add02304d43
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
This doesn't appear to be working on Aurora? :( https://treeherder.mozilla.org/logviewer.html#?job_id=8778578&repo=try
Flags: needinfo?(james)
I guess the __dir__.ini support wasn't in aurora. We could probably just add the pref to the specific ini file for this test there.
Flags: needinfo?(james)
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
WTH, this is failing on Beta41 again. I'm going to push the fix we used for 40, but I wouldn't mind knowing why comment 9 isn't working :( https://treeherder.mozilla.org/logviewer.html#?job_id=461622&repo=mozilla-beta
Flags: needinfo?(james)
And again for beta42, I don't think this entirely exactly works. https://hg.mozilla.org/releases/mozilla-beta/rev/59ba49e25eab
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
I am mildly bemused. It appears to work for me locally when running via mozharness with the same revision that failed on th.
Flags: needinfo?(james)
The amusement fades. This time there's more, https://treeherder.mozilla.org/logviewer.html#?job_id=685457&repo=mozilla-beta and https://treeherder.mozilla.org/logviewer.html#?job_id=685367&repo=mozilla-beta, and this time I "fixed" it by just hiding the affected chunks. After you fix it, remind me I did that and that I need to unhide them, because I'll forget within hours.
Flags: needinfo?(james)
FWIW the reason for this turned out to be that the __dir__.ini stuff was broken on Windows for reasons involving \ vs / I *think* this is now fixed on nightly and so this problem should stop happening in the future. I'll fix this instance.
Flags: needinfo?(james)
Yeah, this is fixed now.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: