Various layout reftest failures when Gecko 40 merges to beta

VERIFIED FIXED in Firefox 40

Status

()

Core
Layout
--
major
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: jfkthame)

Tracking

Trunk
mozilla41
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 verified, firefox41 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1161033 +++

+++ This bug was initially created as a clone of Bug #1157691 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=7279836&repo=try

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-1a.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-1b.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-1c.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-1d.html | image comparison (==), max difference: 255, number of differing pixels: 540321
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-2a.html | image comparison (==), max difference: 255, number of differing pixels: 201592
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-2b.html | image comparison (==), max difference: 255, number of differing pixels: 201592
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vlr-2c.html | image comparison (==), max difference: 255, number of differing pixels: 201592
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-1a.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-1b.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-1c.html | image comparison (==), max difference: 255, number of differing pixels: 537471
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-1d.html | image comparison (==), max difference: 255, number of differing pixels: 540321
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-2a.html | image comparison (==), max difference: 255, number of differing pixels: 201592
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-2b.html | image comparison (==), max difference: 255, number of differing pixels: 201592
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/float-in-rtl-vrl-2c.html | image comparison (==), max difference: 255, number of differing pixels: 201592
Flags: needinfo?(jfkthame)
(Reporter)

Updated

3 years ago
Blocks: 1150614
No longer blocks: 1157142
(Assignee)

Comment 1

3 years ago
Created attachment 8602710 [details] [diff] [review]
Ensure the vertical-text.enabled pref is set for reftests that involve vertical writing modes

This should keep the tests passing even after they go to Beta.
Attachment #8602710 - Flags: review?(smontagu)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Flags: needinfo?(jfkthame)
Attachment #8602710 - Flags: review?(smontagu) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/647d7c637c7b
(Assignee)

Comment 3

3 years ago
Comment on attachment 8602710 [details] [diff] [review]
Ensure the vertical-text.enabled pref is set for reftests that involve vertical writing modes

Requesting uplift as this didn't get merged to m-c in time to catch the mozilla-40 train yesterday.

Approval Request Comment
[Feature/regressing bug #]: tests from bug 1150614 will fail on Beta
[User impact if declined]: n/a, test manifest update only
[Describe test coverage new/current, TreeHerder]: this is all about tests that are running on treeherder :)
[Risks and why]: no code change
[String/UUID change made/needed]: n/a
Attachment #8602710 - Flags: approval-mozilla-aurora?
(Reporter)

Comment 4

3 years ago
Comment on attachment 8602710 [details] [diff] [review]
Ensure the vertical-text.enabled pref is set for reftests that involve vertical writing modes

Test-only changes don't need approval.
Attachment #8602710 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/647d7c637c7b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 6

3 years ago
checkin-needed for Aurora, if the tree ever opens.
Keywords: checkin-needed
(Reporter)

Updated

3 years ago
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
(Reporter)

Updated

3 years ago
Flags: needinfo?(ryanvm)
(Reporter)

Comment 7

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/0af65151a322
status-firefox40: affected → fixed
Flags: in-testsuite+
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.