Closed
Bug 1162490
Opened 9 years ago
Closed 9 years ago
[regression] Normal Windows have no drop-shadow using developer-theme
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: metasieben, Assigned: bgrins)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.25 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Since yesterdays Nightly(2015-05-06) the main window doesn't show the typical drop-shadow anymore when using the developer-theme, however private windows do.
Comment 1•9 years ago
|
||
On which (version of which) OS (the bugreport field says OS X; is this accurate and if so, yosemite or 10.9 or something else?)? Can you provide a screenshot?
Flags: needinfo?(mozilla)
Keywords: regression
Comment 2•9 years ago
|
||
I can reproduce this with latest nightly on OS X 10.9, at least...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mozilla)
Comment 3•9 years ago
|
||
Markus, this seems like a Cocoa thing... any idea what's up?
Component: Theme → Widget: Cocoa
Flags: needinfo?(mstange)
Keywords: regressionwindow-wanted
Product: Firefox → Core
Comment 4•9 years ago
|
||
tn, any chance this was bug 1159772? m-c regression window seems to be: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c93d46ab92f&tochange=60349cbc3d4e per comment #0, looking at inbound right now to narrow it down further.
Flags: needinfo?(tnikkel)
Comment 5•9 years ago
|
||
Interestingly, on bad builds I see the top of the window (near the tabbar etc.) losing shadow first, as soon as I change the theme, but the bottom keeps it until I switch apps and back again...
Comment 6•9 years ago
|
||
Brian, looks like changing the accentcolor regressed this. Reverting that change fixes this issue...
Flags: needinfo?(tnikkel)
Flags: needinfo?(mstange)
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #6) > Brian, looks like changing the accentcolor regressed this. Reverting that > change fixes this issue... I'll take a look. Sounds like an issue with the lightweight theming system. I guess as a workaround we could only set the accentcolor in windows (since it's the only platform that needs the transparent background on the root element.
Comment 8•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #7) > (In reply to :Gijs Kruitbosch from comment #6) > > Brian, looks like changing the accentcolor regressed this. Reverting that > > change fixes this issue... > > I'll take a look. Sounds like an issue with the lightweight theming system. > I guess as a workaround we could only set the accentcolor in windows (since > it's the only platform that needs the transparent background on the root > element. Indeed. Part of me would prefer to figure out why this is breaking things on OS X...
Updated•9 years ago
|
Keywords: regressionwindow-wanted
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #8) > (In reply to Brian Grinstead [:bgrins] from comment #7) > > (In reply to :Gijs Kruitbosch from comment #6) > > > Brian, looks like changing the accentcolor regressed this. Reverting that > > > change fixes this issue... > > > > I'll take a look. Sounds like an issue with the lightweight theming system. > > I guess as a workaround we could only set the accentcolor in windows (since > > it's the only platform that needs the transparent background on the root > > element. > > Indeed. Part of me would prefer to figure out why this is breaking things on > OS X... I would have to imagine any lightweight theme using a transparent (or maybe even semitransparent) accentcolor will have this issue. I can't reproduce on 10.10 and don't have a dev environment set up with 10.9. I can proceed with preprocessing the accentcolor for Windows only, but that's the best I can think of right now (unless if there is a way to repro on 10.10)
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 10•9 years ago
|
||
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment 11•9 years ago
|
||
Comment on attachment 8602780 [details] [diff] [review] accentcolor.patch Review of attachment 8602780 [details] [diff] [review]: ----------------------------------------------------------------- rs=me but please file a separate Core :: Widget: cocoa bug about the transparent accentcolor causing issues on OS X, and cc me and needinfo mstange there. :-)
Attachment #8602780 -
Flags: review+
Comment 12•9 years ago
|
||
Please do :-)
Assignee | ||
Comment 13•9 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/067e21985d8d
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/067e21985d8d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•