Closed Bug 1162516 Opened 9 years ago Closed 9 years ago

Remove FrameSendFailureError symbol

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ato, Assigned: martijn.martijn)

References

Details

Attachments

(2 files)

[gaia] andreastt:bug_1162516 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
davehunt
: review+
Details | Review
[gaia] mwargers:1162516 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
jlorenzo
: review+
njpark
: review+
Details | Review 
Bug 1159674 introduced NoSuchWindowException as a backwards compatibility measure before bug 1155703 lands which removes FrameSendFailureError and FrameNotInitializedError.

We need to do this before landing 1162515.
Depends on: 1162515
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8602750 [details] [review]
[gaia] andreastt:bug_1162516 > mozilla-b2g:master

Note that tests will fail until bug 1155703 lands in Gecko.
Attachment #8602750 - Flags: review?(dave.hunt)
Blocks: 1162515
No longer depends on: 1162515
Attachment #8602750 - Flags: review?(dave.hunt) → review+
I'm using workarounds in bug 1166330 and bug 1109213 that get rid of this try.. except.. calls at all, because they don't seem to work well, causing errors afterwards.
Rebased and rerunning tests.
(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> I'm using workarounds in bug 1166330 and bug 1109213 that get rid of this
> try.. except.. calls at all, because they don't seem to work well, causing
> errors afterwards.

Sorry, this comment was perhaps unclear. Basically, with the gaia UI tests, when we try to catch this NoSuchWindowException exception, we still fail afterwards. I filed bug 1164078 for it.
Actually, FrameSendFailureError is only mentioned once and it can be removed there:
http://mxr.mozilla.org/gaia/search?string=FrameSendFailureError
Attachment #8656922 - Flags: review?(npark)
Attachment #8656922 - Flags: review?(jlorenzo)
Comment on attachment 8656922 [details] [review]
[gaia] mwargers:1162516 > mozilla-b2g:master

After a |git grep FrameSendFailureError|, I confirm your conclusions, Martijn!
Attachment #8656922 - Flags: review?(jlorenzo) → review+
Comment on attachment 8656922 [details] [review]
[gaia] mwargers:1162516 > mozilla-b2g:master

LGTM
Attachment #8656922 - Flags: review?(npark) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/1fe6d30b00129b14cc8b6e18b7120d3b15561e1c
Assignee: ato → martijn.martijn
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: