Closed Bug 1162518 Opened 6 years ago Closed 5 years ago

Fix-up SeaMonkey browser tests after file move

Categories

(SeaMonkey :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(firefox40 affected)

RESOLVED FIXED
seamonkey2.38
Tracking Status
firefox40 --- affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file)

The test files under suite/browser/test were organised into sub-directories but the tests were not updated to reflect the new locations. This patch attempts to do that.
If you happen to know which patch did the move, please reference it.
Attachment #8602744 - Flags: review?(philip.chee)
Comment on attachment 8602744 [details] [diff] [review]
Update file locations [Checked in: Comment 2]

rs=me test fixes.

> The test files under suite/browser/test were organised into sub-directories
> but the tests were not updated to reflect the new locations. This patch
> attempts to do that.
> If you happen to know which patch did the move, please reference it.
This is an artefact of the old makefile magic used to determine where to place the test files vs the new moz.build magic.

Specifically the use of |addprefix foo| as seen in:

> libs:: $(addprefix mochitest/, $(_TEST_FILES))
> 	$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)

>  const REDIRECT_FROM = "https://example.com/browser/suite/browser/test/" +
> -                      "redirect_bug623155.sjs";
> +                      "browser/redirect_bug623155.sjs";

const REDIRECT_FROM = "https://example.com/browser/suite/browser/test/browser" +
                      "redirect_bug623155.sjs";

> -  let testURI = "http://example.com/browser/" +
> -    "suite/browser/test/browser_privatebrowsing_protocolhandler_page.html";
> +  let testURI = "http://example.com/browser/suite/" +
> +    "browser/test/browser/browser_privatebrowsing_protocolhandler_page.html";

let testURI = "http://example.com/browser/" +
  "suite/browser/test/browser/browser_privatebrowsing_protocolhandler_page.html";

You probably need to check all the old makefiles for the addprefix usage.
Attachment #8602744 - Flags: review?(philip.chee) → review+
Comment on attachment 8602744 [details] [diff] [review]
Update file locations [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/82af2da6e32d
Attachment #8602744 - Attachment description: Update file locations → Update file locations [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.38
You need to log in before you can comment on or make changes to this bug.