Closed Bug 1162520 Opened 9 years ago Closed 9 years ago

crash in DrawingContext::FillRectangle(D2D_RECT_F const*, ID2D1Brush*)

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
36 Branch
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox38 - wontfix
firefox38.0.5 + wontfix
firefox39 + fixed
firefox40 --- fixed

People

(Reporter: u279076, Assigned: bas.schouten)

References

Details

(Keywords: crash, topcrash)

Crash Data

+++ This bug was initially created as a clone of Bug #1154003 +++

+++ This bug was initially created as a clone of Bug #1089454 +++

More reports are coming in with the same signature as tracked in bug 1089454, which are really "we don't recover well from driver resets", so it's somewhat expected.  Here are the new items after the bug was marked fixed, from the last few comments in bug 1089454:

---------------
I encountered this crash https://crash-stats.mozilla.com/report/index/ccb67422-af23-43fc-960f-915862150401 during my testing around loop tab share, on Firefox 38 Beta 1 (20150330154247) using Windows 8.1 32bit.
---------------
Crash on http://reshade.me/
https://crash-stats.mozilla.com/report/index/1fb536a4-8832-41e2-ac5c-955112150411
AMD driver restart after crash.  This crash on FF 38 beta3.
---------------

Cloned bug 115003 to address some edgecases. In particular, Stas Denisov reports seeing these crashes every time he plays http://www.youtube.com/embed/YaNz4DlGuqw.

bp-80f9e177-1cf7-476a-9e8f-91c342150504
bp-a35c5505-708b-4a7a-9aa8-8a0f62150507
bp-2461cfa6-ba5c-43c3-9ac7-781ae2150501
[Tracking Requested - why for this release]: nominating to track to match the parent bug.
status-firefox38: --- → affected
tracking-firefox38: --- → ?
> (In reply to Bas Schouten (:bas.schouten))
> > Also, did you notice anything like your screen flashing or a
> > graphics driver reset notification around the bottom left of your screen?
> 
> Yes, browser freezes and after a few seconds black screen appears. Display
> driver stopped responding and has recovered.

I don't know why but youtube video does not cause crash anymore.
Assignee: nobody → bas
(In reply to Stas Denisov from comment #5)
> https://crash-stats.mozilla.com/report/index/6590ff10-c5d1-4569-94c9-
> 3dfeb2150511

This is a crash on beta, I'm hoping this is fixed on inbound.
(In reply to Bas Schouten (:bas.schouten) from comment #6)
> This is a crash on beta, I'm hoping this is fixed on inbound.

Out of interest, what has landed on inbound and not on beta that would affect this? I'd be eager to track that.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #7)
> (In reply to Bas Schouten (:bas.schouten) from comment #6)
> > This is a crash on beta, I'm hoping this is fixed on inbound.
> 
> Out of interest, what has landed on inbound and not on beta that would
> affect this? I'd be eager to track that.

Bug 1161815 should (almost) completely have eliminated this crash. That's what I'm hoping at least.
(In reply to Bas Schouten (:bas.schouten) from comment #8)
> Bug 1161815 should (almost) completely have eliminated this crash. That's
> what I'm hoping at least.

Thanks, that's good to know, will keep an eye out for that!
https://crash-stats.mozilla.com/report/index/250b5cdc-6626-4f32-be7a-9a9a52150513

I received this crash today.  I had a lot of tabs open to various sites and was trying to open a new window at the time.  I hit the wrong button a few times (opening a new private window and a new tab) and at some point when I was trying to close them, the browser crashed.

Please let me know if there is any more information I can provide to help.  Thanks.
This is a scenario where we "survived" almost 3k critical errors before we went down; doesn't appear to be OOM.  I wouldn't expect this crash to be fixed on 38 though, it landed on 40, and we're trying to uplift it to 39.
Too late for 38 but tracking to know if we fixed it or not.
status-firefox38: affected → wontfix
status-firefox38.0.5: --- → affected
status-firefox39: --- → affected
tracking-firefox38: ? → -
tracking-firefox38.0.5: --- → +
tracking-firefox39: --- → +
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #9)
> (In reply to Bas Schouten (:bas.schouten) from comment #8)
> > Bug 1161815 should (almost) completely have eliminated this crash. That's
> > what I'm hoping at least.
> 
> Thanks, that's good to know, will keep an eye out for that!

And it looks like on Nightly those crashes have stopped after the build that has this patch, while on Aurora they stopped with the uplift of 40. So, all in all looks good so far!

Should we mark this bug a dupe of that one, or mark it fixed (on those channels)?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #13)
> (In reply to Robert Kaiser (:kairo@mozilla.com) from comment #9)
> > (In reply to Bas Schouten (:bas.schouten) from comment #8)
> > > Bug 1161815 should (almost) completely have eliminated this crash. That's
> > > what I'm hoping at least.
> > 
> > Thanks, that's good to know, will keep an eye out for that!
> 
> And it looks like on Nightly those crashes have stopped after the build that
> has this patch, while on Aurora they stopped with the uplift of 40. So, all
> in all looks good so far!
> 
> Should we mark this bug a dupe of that one, or mark it fixed (on those
> channels)?

It's tricky, this bug was probably still a valid concern and fixes a valid concern. The other one just fixes more of the crashes. We can mark this fixed I'd say.
Then let's mark it fixed on 39 and 40.
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: affected → fixed
status-firefox40: --- → fixed
Resolution: --- → FIXED
Too late to do anything for 38.0.5
status-firefox38.0.5: affected → wontfix
Is it really "fixed"?

https://crash-stats.mozilla.com/report/index/4d395779-b0f2-4d97-ab59-b77462150601

There are two other bugs with the same signature as here, and they are "fixed", too. 

How to determine is my crash relates to this bug, other two, or has to be filed as separate bug?
(In reply to User Dderss from comment #17)
> https://crash-stats.mozilla.com/report/index/4d395779-b0f2-4d97-ab59-b77462150601

Your crash is from version 38.0.1 and this is not fixed in that version. It's only fixed in Firefox 39 (which is in beta right now) and newer versions.
Crash Signature: , ID2D1Brush*)] [@ D2DDeviceContextBase<ID2D1DeviceContext, ID2D1DeviceContext, null_type>::DrawImage(ID2D1Image*, D2D_POINT_2F const*, D2D_RECT_F const*, D2D1_INTERPOLATION_MODE, D2D1_COMPOSITE_MODE) ] [@ d2d1.dll@0x847d7] → , ID2D1Brush*)] [@ D2DDeviceContextBase<ID2D1DeviceContext, ID2D1DeviceContext, null_type>::DrawImage(ID2D1Image*, D2D_POINT_2F const*, D2D_RECT_F const*, D2D1_INTERPOLATION_MODE, D2D1_COMPOSITE_MODE) ] [@ d2d1.dll@0x847d7] [@ D2DDeviceContextBase<T>::…
(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)
> Lots of ESR38 reports with this signature. Should we uplift this?
> https://crash-stats.mozilla.com/report/
> list?range_unit=days&range_value=28&signature=DrawingContext%3A%3AFillRectang
> le#tab-reports

I'm 'okayish' with uploading the patch from bug 1161815.
Flags: needinfo?(bas)
Crash Signature: , D2D1_COMPOSITE_MODE) ] [@ d2d1.dll@0x847d7] [@ D2DDeviceContextBase<T>::FillRectangle(D2D_RECT_F const*, ID2D1Brush*)] [@ DrawingContext::FillRectangle ] [@ DrawingContext::FillGeometry ] [@ D2DDeviceContextBase<T>::FillRectangle ] → , D2D1_COMPOSITE_MODE) ] [@ d2d1.dll@0x847d7] [@ D2DDeviceContextBase<T>::FillRectangle(D2D_RECT_F const*, ID2D1Brush*)] [@ DrawingContext::FillRectangle] [@ DrawingContext::FillGeometry ] [@ D2DDeviceContextBase<T>::FillRectangle ]
You need to log in before you can comment on or make changes to this bug.