Fix connect/accept in |UnixSocketWatcher|

RESOLVED FIXED in Firefox 40

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

(Blocks: 1 bug)

unspecified
2.2 S12 (15may)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

The |Connect| method in |UnixSocketWatcher| incorrectly returns an error if it takes longer on a non-blocking socket. That is not an error.

Accepting connection requests should be moved out of |UnixSocketWatcher|. This will allow for more flexibility.
Created attachment 8602760 [details] [diff] [review]
[01] Bug 1162524: Fix error handling |UnixSocketWatcher::Connect|
Attachment #8602760 - Flags: review?(kyle)
Created attachment 8602761 [details] [diff] [review]
[02] Bug 1162524: Move |accept| out of |UnixSocketWatcher|
Attachment #8602761 - Flags: review?(kyle)
Blocks: 1162585
https://hg.mozilla.org/mozilla-central/rev/7f7d734605b1
https://hg.mozilla.org/mozilla-central/rev/a099b6c77366
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
You need to log in before you can comment on or make changes to this bug.