Closed Bug 1162548 Opened 9 years ago Closed 9 years ago

[Calendar] edit and modify event views should not talk directly to stores

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mmedeiros, Assigned: mmedeiros)

References

Details

Attachments

(3 files)

[gaia] millermedeiros:1162548-event-store-bridge > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
[gaia] gaye:bug-1168498 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30377
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
we need to create some sort of "bridge" to isolate the frontend from the backend and avoid talking to the stores/db (since we will move the database calls into the worker soon)
Blocks: 1162586
Assignee: nobody → mmedeiros
Summary: [Calendar] views should not talk directly to stores → [Calendar] edit and modify event views should not talk directly to stores
Attachment #8603595 - Flags: review?(gaye)
Comment on attachment 8603595 [details] [review]
[gaia] millermedeiros:1162548-event-store-bridge > mozilla-b2g:master

Awesome work!!
Attachment #8603595 - Flags: review?(gaye) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out in bug 1168498 since this broke creating google calendar events
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
this should fix the google calendar error (was using the wrong calendar id on the `<option>`)
Attachment #8614456 - Flags: review?(gaye)
Comment on attachment 8614456 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30377

Nice one!
Attachment #8614456 - Flags: review?(gaye) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/0b00f058eeee79a05345b793eb5efa19f166ab3f
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: