Closed Bug 1162608 Opened 5 years ago Closed 5 years ago

Import updated -webkit-radial-gradient conversion code from https://github.com/hallvors/css-fixme/issues/9

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file, 1 obsolete file)

Filing this to follow up on the parenthetical in bug 1132748 comment 29:
> (Also, I ran across some issues with -webkit-radial-gradient unprefixing and
> filed https://github.com/hallvors/css-fixme/issues/9 . I'm not gating this
> on that fix for the moment, since I don't know that any of the sites where
> we're unprefixing actually run up against that bug anyway.)

hallvors fixed this in cssfixme here:
https://github.com/hallvors/css-fixme/commit/92d9e44a38d0439da926839362affe72214fccb8


This bug tracks importing that fix (and updating the mochitest accordingly).
Attached patch fix v1 (obsolete) — Splinter Review
Here's the patch. I just copypasted in the updated chunk of code, and swapped in 'aPrefixedFuncBody' and 'unprefixedFuncName' as-appropriate.

This patch also uncomments the mochitest testcase for this syntax. (My guesses at the expected values weren't quite right, so I had to tweak them slightly.)
Attachment #8602882 - Flags: review?(hsteen)
Attached patch fix v2Splinter Review
er, previous patch had a random blank line in the mochitest; cleaned that up here.
Attachment #8602882 - Attachment is obsolete: true
Attachment #8602882 - Flags: review?(hsteen)
Attachment #8602884 - Flags: review?(hsteen)
Flags: in-testsuite?
Comment on attachment 8602884 [details] [diff] [review]
fix v2

Review of attachment 8602884 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - only question: I see you changed the test from expecting "bottom right" to expecting "right bottom" - that's how Gecko itself serializes it and is not related to what my JS is doing - or? Just curioust :)
Attachment #8602884 - Flags: review?(hsteen) → review+
(In reply to Hallvord R. M. Steen [:hallvors] from comment #3)
> Looks good to me - only question: I see you changed the test from expecting
> "bottom right" to expecting "right bottom" - that's how Gecko itself
> serializes it and is not related to what my JS is doing - or?

Yup, exactly.

(The unprefixed style gets put directly into the parser, so this mochitest doesn't get a chance to directly inspect it.  We can, however, read elem.style (which generates a string based on an internal representation of the specified style) and getComputedStyle (which generates a string based on the computed style). Each of these involve some reserialization.)
Flags: in-testsuite? → in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/fefdeb41a9be
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.