1162619 - Synced Tabs disappear after refresh

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

STR:

1) On desktop, open a few tabs, Sync
2) On iOS, log in, go to the Synced Tabs panel
3) You should see the tabs you synced
4) Open a tab
5) Tap the address bar and open the Synced Tabs panel again

Expected: tabs are still there.

Actual: Device shows, but no synced tabs under it.

Comment 1

[Aaron Train [:aaronmt]]

I see this too (iPhone 6, 8.3), latest code

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Resetting the simulator and logging in on a clean profile shows the tabs again. So that confirms that they are still on the server.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Quiting and restarting the simulator does not show the tabs. It shows the devices but no tabs. Pull to refresh makes no change. Something local state it seems. Investigating.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

sqlite> select * from tabs;
.. nothing ..

sqlite> select * from clients;
6_vaPEKAdrhc|Stefan's TestFlight Profile|1431017553820|desktop||Darwin
Pjf1r25WT7SQ|Firefox|1430926396220|mobile|phone|iOS
lZhwm1A/aW9Q|Fennec (sarentz) on iPhone Simulator|1430926107890|mobile|simulator|iOS

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Directly after clicking the Synced Tabs panel for the first time:

sqlite> select * from tabs;
1|6_vaPEKAdrhc|http://daringfireball.net/|Daring Fireball||1430925953000
2|6_vaPEKAdrhc|https://www.mozilla.org/en-US/about/manifesto/|The Mozilla Manifesto||1430925951000
3|6_vaPEKAdrhc|http://www.apple.com/watch/|Apple - Apple Watch||1430925946000

So it seems something wipes the table after that.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Initial Sync

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Pull to Refresh

Comment 8

[Richard Newman [:rnewman]]

updateMetadata is never called in ClientsSynchronizer.

That means lastFetched is always zero.

As a result, we always wipe and fetch all clients.

When we wipe the clients DB, our delete cascades to tabs:

            "client_guid TEXT REFERENCES clients(guid) ON DELETE CASCADE",

but our tabs sync respects our lastFetched, sees no change on the server, and doesn't re-fetch.

The fix is to add the missing updateMetadata chain.

An additional fix is to make sure we wipe (and set lastFetched to zero) in the tabs engine when we wipe clients.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/432

Comment 10

[Richard Newman [:rnewman]]

Comment on attachment 8602869 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/432

LGTM!