Call PORT_SetError after calling SSL3_SendAlert

RESOLVED FIXED in 3.19.1

Status

P2
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

3.19
3.19.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8602861 [details] [diff] [review]
Proposed patch

The proposed patch changes ssl3ext.c to call PORT_SetError
after the SSL3_SendAlert calls. This is a pattern we follow
when convenient. The reason is that any function we call
after PORT_SetError may potentially change the error code,
even if the function succeeds. NSS functions, like most
other library functions, only guarantee the error code is
correctly set if they fail.

(The SSL3_SendAlert calls I modified seem to be newly
added in bug 753136.)
Attachment #8602861 - Flags: review?(martin.thomson)

Updated

3 years ago
Attachment #8602861 - Flags: review?(martin.thomson) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.