Closed Bug 1162646 Opened 5 years ago Closed 5 years ago

Enable eslint rules for Loop: no trailing spaces

Categories

(Hello (Loop) :: Client, defect, P3)

defect
Points:
1

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed
Blocking Flags:
backlog tech-debt

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

This is largely simple to turn on, we just need to ignore the generated jsx files which we shouldn't need to lint (as we lint the sources), and they have masses of trailing white spaces.

I have a patch for this coming up.
Flags: qe-verify-
Flags: firefox-backlog+
Simple patch - ignore the jsx files, and turn on no trailing whitespace :-) No existing trailing whitespace so even better!
Attachment #8602862 - Flags: review?(dmose)
I forgot to say, whilst we could move these in the hierarchy, I don't think its worth it at the moment. I'd rather spend the time on hooking react into the build system if we were going to do anything.
Comment on attachment 8602862 [details] [diff] [review]
Enable eslint rules for Loop: no trailing spaces.

r=dmose
Attachment #8602862 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/0e5e9c5ac6f3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.