Add preffed SpeechSynthesisUtterance.chosenVoiceURI for testing purposes

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We need to test correct voice selection in content mochitests. Currently, we do that with implementing a service via SpecialPowers. This doesn't work well with e10s tests, so it would be nice if there was a lightweight way of knowing what voice was ultimately chosen for a spoken utterance.
Assignee: nobody → eitan
Comment on attachment 8602940 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes.

> }
> 
>+
> nsresult

Don't add that extra new line.

Would [ChromeOnly] work for chosenVoiceURI?
But Pref is fine too.
Attachment #8602940 - Flags: review?(bugs) → review+
Made it ChromeOnly and removed newline.
Carrying over r+
Attachment #8602940 - Attachment is obsolete: true
Comment on attachment 8603081 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. r=smaug

I meant only ChromeOnly, not both ChromeOnly and Pref ;)
Good point! I'll change that before pushing.
Blocks: 1162699
Looks like we were crashing when activating the screen reader with no available voices. We were dereferencing a null pointer.

I'll move that line after the null-check and it should be good. Try is happy.
Flags: needinfo?(eitan)
https://hg.mozilla.org/mozilla-central/rev/896c165d880b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.