Add preffed SpeechSynthesisUtterance.chosenVoiceURI for testing purposes

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We need to test correct voice selection in content mochitests. Currently, we do that with implementing a service via SpecialPowers. This doesn't work well with e10s tests, so it would be nice if there was a lightweight way of knowing what voice was ultimately chosen for a spoken utterance.
(Assignee)

Updated

4 years ago
Assignee: nobody → eitan
(Assignee)

Comment 1

4 years ago
Created attachment 8602940 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes.
Attachment #8602940 - Flags: review?(bugs)
Comment on attachment 8602940 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes.

> }
> 
>+
> nsresult

Don't add that extra new line.

Would [ChromeOnly] work for chosenVoiceURI?
But Pref is fine too.
Attachment #8602940 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8603081 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. r=smaug

Made it ChromeOnly and removed newline.
Carrying over r+
Attachment #8602940 - Attachment is obsolete: true
Comment on attachment 8603081 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. r=smaug

I meant only ChromeOnly, not both ChromeOnly and Pref ;)
(Assignee)

Comment 5

4 years ago
Good point! I'll change that before pushing.
(Assignee)

Updated

4 years ago
Blocks: 1162699
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/05e4643b27ec for apparently causing the Gip(a) permafail on inbound:

https://treeherder.mozilla.org/logviewer.html#?job_id=9712726&repo=mozilla-inbound
Flags: needinfo?(eitan)
(Assignee)

Comment 8

4 years ago
Looks like we were crashing when activating the screen reader with no available voices. We were dereferencing a null pointer.

I'll move that line after the null-check and it should be good. Try is happy.
Flags: needinfo?(eitan)
https://hg.mozilla.org/mozilla-central/rev/896c165d880b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.