Remove XULAPP_DEFINES from DOM Inspector

RESOLVED FIXED in Firefox 40

Status

Other Applications
DOM Inspector
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
mozilla40

Firefox Tracking Flags

(firefox40 fixed, seamonkey2.37 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1155283 is planning to remove XULAPP_DEFINES, so need to fix DOM Inspector so it does not use it.
(Assignee)

Comment 1

3 years ago
Created attachment 8603308 [details] [diff] [review]
Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #8603308 - Flags: review?(philip.chee)

Comment 2

3 years ago
Comment on attachment 8603308 [details] [diff] [review]
Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]

> +DEFINES = -DDOMi_VERSION=$(DOMi_VERSION)
DEFINES += -DDOMi_VERSION=$(DOMi_VERSION)

r=me (assuming that it works)
Attachment #8603308 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8603308 [details] [diff] [review]
Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]

With suggested tweak
http://hg.mozilla.org/dom-inspector/rev/a60fa07fdae5
Attachment #8603308 - Attachment description: Remove use of XULAPP_DEFINES from DOM Inspector → Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]
(Assignee)

Updated

3 years ago
status-firefox40: affected → fixed
status-seamonkey2.37: --- → fixed
Target Milestone: --- → mozilla40
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.