1162704 - Create branches according to the Firefox train versions

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To support different versions of Firefox we have to create appropriate branches in the firefox-ui-tests repository. It will look that way:

master -> mozilla-central
mozilla-aurora -> releases/mozilla-aurora
mozilla-beta -> releases/mozilla-beta
mozilla-release -> releases/mozilla-release
mozilla-esr38 -> releases/mozilla-esr38

Given that we backported all important fixes for Marionette to 38.0, all of our tests should work across those newly to create branches. But I will double check before pushing to the upstream repo.

Armen can you please check my proposal and give feedback if those branch names are ok with you? Thanks

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Before we do the branching I would like to fix bug 1145638 first, so we have a consistent basis for tests across the branches.

Comment 2

[Armen [:armenzg]]

That works for me.
What do you think about documenting it on the docs that we're following this agreement?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In case of Aurora the only test which is failing is TestSafeBrowsingWarningPages.test_warning_pages. But that is because of the change in bug 1147212 and 1162070. I will have to get that reverted.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Armen Zambrano G. (:armenzg - Toronto) from comment #2)
> That works for me.

Great. So I will get started with mozilla-aurora in a moment.

> What do you think about documenting it on the docs that we're following this
> agreement?

The documentation has to be added to the wiki of the firefox-ui-tests repository. I don't want to have it at a different location. As close to the code is always better. If you need something in your docs, you can simple link to that wiki page.

Comment 5

[DONT USE THIS ACCOUNT TO CC ME - Armen Z.G.]

Yes, I meant the repo. I'm glad we're on the same page.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: mozilla-aurora branch

Just a formal review please. As mentioned already above the safebrowsing warning pages test is the only one which is failure for Aurora and needs to be reverted.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8603539 [details] [review]
mozilla-aurora branch

I'm going to remove this review request given that is simply the former version of the test.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The branch mozilla-aurora has been created:
https://github.com/mozilla/firefox-ui-tests/tree/mozilla-aurora

mozilla-beta and mozilla-release I will do on Monday.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The branch mozilla-beta has also been created:
https://github.com/mozilla/firefox-ui-tests/tree/mozilla-beta

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also created mozilla-release and mozilla-esr38:
https://github.com/mozilla/firefox-ui-tests/tree/mozilla-release
https://github.com/mozilla/firefox-ui-tests/tree/mozilla-esr38

Please note that tests for those two branches will fail as long as we do not have an officially released build of Firefox 38 on the FTP server. Best option here would always be to use the latest candidate build but that is not possible yet. See also https://github.com/mozilla/mozdownload/issues/273.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All what we can do on this bug is done right now.