1162729 - CORS check is always performed when fetching a manifest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

The spec requires that a CORS check is performed when fetching a manifest.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-Bug-1162729-CORS-check-is-always-performed-when-fetc.patch

Forcing CORS on all manifest requests.

Comment 2

[Marcos Caceres [:marcosc]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e02f14b20

Comment 3

[:ehsan akhgari]

Comment on attachment 8603009 [details] [diff] [review]
0001-Bug-1162729-CORS-check-is-always-performed-when-fetc.patch

Review of attachment 8603009 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/test/browser_ManifestObtainer_obtain.js
@@ +53,5 @@
>        const URL = `${defaultURL}?${query.join('&')}`;
>        return URL;
>      },
> +    run(err) {
> +      Assert.strictEqual(err.name, 'TypeError', this.expected);

FWIW, is() now performs strict equality checks (as of bug 949614), so there is no point to using the more verbose Assert.jsm API.

Comment 4

[Marcos Caceres [:marcosc]]

Try link above was wrong:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e02f14b202ef

Comment 5

[Marcos Caceres [:marcosc]]

(none of the failures appear related to my code... sent request to run those tests again)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f77c6a5d17d7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f77c6a5d17d7