Closed
Bug 1162729
Opened 11 years ago
Closed 11 years ago
CORS check is always performed when fetching a manifest
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
2.40 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The spec requires that a CORS check is performed when fetching a manifest.
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mcaceres
| Assignee | ||
Comment 1•11 years ago
|
||
Forcing CORS on all manifest requests.
Attachment #8603009 -
Flags: review?(ehsan)
| Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8603009 [details] [diff] [review]
0001-Bug-1162729-CORS-check-is-always-performed-when-fetc.patch
Review of attachment 8603009 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/manifest/test/browser_ManifestObtainer_obtain.js
@@ +53,5 @@
> const URL = `${defaultURL}?${query.join('&')}`;
> return URL;
> },
> + run(err) {
> + Assert.strictEqual(err.name, 'TypeError', this.expected);
FWIW, is() now performs strict equality checks (as of bug 949614), so there is no point to using the more verbose Assert.jsm API.
Attachment #8603009 -
Flags: review?(ehsan) → review+
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
| Assignee | ||
Comment 4•11 years ago
|
||
Try link above was wrong:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e02f14b202ef
| Assignee | ||
Comment 5•11 years ago
|
||
(none of the failures appear related to my code... sent request to run those tests again)
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•