Closed Bug 1162729 Opened 5 years ago Closed 5 years ago

CORS check is always performed when fetching a manifest

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

The spec requires that a CORS check is performed when fetching a manifest.
Assignee: nobody → mcaceres
Forcing CORS on all manifest requests.
Attachment #8603009 - Flags: review?(ehsan)
No longer blocks: 1143898
Comment on attachment 8603009 [details] [diff] [review]
0001-Bug-1162729-CORS-check-is-always-performed-when-fetc.patch

Review of attachment 8603009 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/test/browser_ManifestObtainer_obtain.js
@@ +53,5 @@
>        const URL = `${defaultURL}?${query.join('&')}`;
>        return URL;
>      },
> +    run(err) {
> +      Assert.strictEqual(err.name, 'TypeError', this.expected);

FWIW, is() now performs strict equality checks (as of bug 949614), so there is no point to using the more verbose Assert.jsm API.
Attachment #8603009 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
(none of the failures appear related to my code... sent request to run those tests again)
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f77c6a5d17d7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.