Remove usage of |#ifdef PR_LOGGING| from rdf

RESOLVED FIXED in Firefox 40

Status

()

Core
RDF
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Created attachment 8603012 [details] [diff] [review]
Part 1: Remove instances of #ifdef PR_LOGGING in rdf

PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603012 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Created attachment 8603013 [details] [diff] [review]
Part 2: Wrap expensive calls in PR_LOG_TEST

Check that logging is enabled before performing potentially expensive
operations.
Attachment #8603013 - Flags: review?(nfroyd)
Attachment #8603012 - Flags: review?(nfroyd) → review+
Attachment #8603013 - Flags: review?(nfroyd) → review+
Created attachment 8603472 [details] [diff] [review]
Part 3: Wrap expensive calls in PR_LOG_TEST

Check that logging is enabled before performing potentially expensive
operations.
Attachment #8603472 - Flags: review?(seth)
Comment on attachment 8603472 [details] [diff] [review]
Part 3: Wrap expensive calls in PR_LOG_TEST

Wrong bug!
Attachment #8603472 - Attachment is obsolete: true
Attachment #8603472 - Flags: review?(seth)
https://hg.mozilla.org/mozilla-central/rev/53086148c9aa
https://hg.mozilla.org/mozilla-central/rev/885382fbe653
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.