Closed Bug 1162740 Opened 11 years ago Closed 11 years ago

Remove usage of |#ifdef PR_LOGGING| from rdf

Categories

(Core Graveyard :: RDF, defect)

Product:
Core Graveyard
Component:
RDF
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files, 1 obsolete file)

Part 1: Remove instances of #ifdef PR_LOGGING in rdf
17.36 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 2: Wrap expensive calls in PR_LOG_TEST
5.52 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603012 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Check that logging is enabled before performing potentially expensive operations.
Attachment #8603013 - Flags: review?(nfroyd)
Attachment #8603012 - Flags: review?(nfroyd) → review+
Attachment #8603013 - Flags: review?(nfroyd) → review+
Check that logging is enabled before performing potentially expensive operations.
Attachment #8603472 - Flags: review?(seth)
Comment on attachment 8603472 [details] [diff] [review] Part 3: Wrap expensive calls in PR_LOG_TEST Wrong bug!
Attachment #8603472 - Attachment is obsolete: true
Attachment #8603472 - Flags: review?(seth)
https://hg.mozilla.org/mozilla-central/rev/53086148c9aa https://hg.mozilla.org/mozilla-central/rev/885382fbe653
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: