Closed
Bug 1162740
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from rdf
Categories
(Core Graveyard :: RDF, defect)
Core Graveyard
RDF
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files, 1 obsolete file)
17.36 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
5.52 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Assignee | ||
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603012 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Check that logging is enabled before performing potentially expensive operations.
Attachment #8603013 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=673a3fcd87de
Updated•9 years ago
|
Attachment #8603012 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8603013 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/53086148c9aa https://hg.mozilla.org/integration/mozilla-inbound/rev/885382fbe653
Assignee | ||
Comment 5•9 years ago
|
||
Check that logging is enabled before performing potentially expensive operations.
Attachment #8603472 -
Flags: review?(seth)
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9ad197bc167
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8603472 [details] [diff] [review] Part 3: Wrap expensive calls in PR_LOG_TEST Wrong bug!
Attachment #8603472 -
Attachment is obsolete: true
Attachment #8603472 -
Flags: review?(seth)
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/53086148c9aa https://hg.mozilla.org/mozilla-central/rev/885382fbe653
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•