Closed
Bug 1162748
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from graphics
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file, 1 obsolete file)
45.80 KB,
patch
|
erahm
:
review+
botond
:
feedback+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Assignee | ||
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603059 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ca965051b64
Comment 3•9 years ago
|
||
Comment on attachment 8603059 [details] [diff] [review] Remove instances of #ifdef PR_LOGGING in graphics Review of attachment 8603059 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Logging.h @@ -178,5 @@ > // make the corresponding change in the ShouldOutputMessage method > // above. > if (PreferenceAccess::sGfxLogLevel >= aLevel) { > -#if defined(WIN32) && !defined(PR_LOGGING) > - ::OutputDebugStringA((aNoNewline ? aString : aString+"\n").c_str()); Please also remove the declaration of OutputDebugStringA at the top of this file - this was the only use of it.
Updated•9 years ago
|
Attachment #8603059 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=abbc0661969b
Assignee | ||
Comment 5•9 years ago
|
||
Updated per Botond's request and triggered a few windows builds. Botond, does this look good to you?
Attachment #8603422 -
Flags: feedback?(botond)
Assignee | ||
Updated•9 years ago
|
Attachment #8603059 -
Attachment is obsolete: true
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8603422 [details] [diff] [review] Remove instances of #ifdef PR_LOGGING in graphics Carrying forward r+ from froydnj.
Attachment #8603422 -
Flags: review+
Comment 7•9 years ago
|
||
Comment on attachment 8603422 [details] [diff] [review] Remove instances of #ifdef PR_LOGGING in graphics Review of attachment 8603422 [details] [diff] [review]: ----------------------------------------------------------------- I've only glanced at the rest, but Logging.h looks good to me, thanks! (I assume the performance implications of enabling the code that was protected by '#ifdef PR_LOGGING' unconditionally have been discussed elsewhere, so I won't comment on that.)
Attachment #8603422 -
Flags: feedback?(botond) → feedback+
Comment 8•9 years ago
|
||
(In reply to Botond Ballo [:botond] [at c++ standards meeting May 4-9] from comment #7) > (I assume the performance implications of enabling the code that was > protected by '#ifdef PR_LOGGING' unconditionally have been discussed > elsewhere, so I won't comment on that.) Fun fact: PR_LOGGING has been enabled unconditionally for a while now (one has had to use --disable-logging to, well, disable it, and none of our builds do that by default). So if nobody has complained, that's a good thing!
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3464d56d154d
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3464d56d154d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•