1162789 - Drop HTMLFormControlsCollection::mForm when the it gets destroyed by the cycle collector

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Drop HTMLFormControlsCollection::mForm when the it gets destroyed by the cycle collector

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8603067 [details] [diff] [review]
Drop HTMLFormControlsCollection::mForm when the it gets destroyed by the cycle collector

I think the idea here is that mForm is non-null until the form element is actually about to be deleted.
HTMLFormControlsCollection isn't exactly consistent with null checking mForm, and
this change makes null pointer crashes more likely (if we somehow bring element back to life after unlinking, and that has happened historically).


(I thought you were going to fix some other mForm usage)

Comment 3

[(no longer active)]

Oh, I see.  I'll add a comment about this to the CC macro to make it more obvious.

(The other mForm issue is bug 1162765.)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2623b743e4c3

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2623b743e4c3